enable psm2 nameserver #307

yulujia · 2019-12-12T19:46:23Z

let psm2 use ip:port addr format and use nameserver to resolve it to the
psm2 native addr

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-12T19:47:14Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-12T19:47:15Z

src/test/tests_common.h

@@ -371,6 +371,9 @@ tc_cli_start_basic(char *local_group_name, char *srv_group_name,
 	uint32_t	 grp_size;
 	int		 attach_retries = opts.num_attach_retries;
 	int		 rc = 0;
+	int		 myflag = 0;
+	while (myflag)


(style) Missing a blank line after declarations

daosbuild1 · 2019-12-12T19:47:15Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T19:47:15Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T19:47:18Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/1/execution/node/44/log

daosbuild1 · 2019-12-12T20:07:11Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/1/execution/node/258/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-12T20:27:57Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-12T20:27:57Z

src/test/tests_common.h

@@ -371,6 +371,9 @@ tc_cli_start_basic(char *local_group_name, char *srv_group_name,
 	uint32_t	 grp_size;
 	int		 attach_retries = opts.num_attach_retries;
 	int		 rc = 0;
+	int		 myflag = 0;
+	while (myflag)


(style) Missing a blank line after declarations

daosbuild1 · 2019-12-12T20:27:57Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T20:27:57Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T20:28:02Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/2/execution/node/44/log

daosbuild1 · 2019-12-12T20:47:46Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/2/execution/node/262/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-12T21:43:59Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-12T21:43:59Z

src/test/tests_common.h

@@ -371,6 +371,9 @@ tc_cli_start_basic(char *local_group_name, char *srv_group_name,
 	uint32_t	 grp_size;
 	int		 attach_retries = opts.num_attach_retries;
 	int		 rc = 0;
+	int		 myflag = 0;
+	while (myflag)


(style) Missing a blank line after declarations

daosbuild1 · 2019-12-12T21:43:59Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T21:43:59Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T21:44:03Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/3/execution/node/44/log

daosbuild1 · 2019-12-12T22:03:47Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/3/execution/node/254/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-12T22:17:18Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-12T22:17:18Z

src/test/tests_common.h

@@ -371,6 +371,9 @@ tc_cli_start_basic(char *local_group_name, char *srv_group_name,
 	uint32_t	 grp_size;
 	int		 attach_retries = opts.num_attach_retries;
 	int		 rc = 0;
+	int		 myflag = 0;
+	while (myflag)


(style) Missing a blank line after declarations

daosbuild1 · 2019-12-12T22:17:18Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T22:17:19Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-12T22:17:22Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/4/execution/node/44/log

daosbuild1 · 2019-12-12T22:37:56Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/4/execution/node/251/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-13T00:49:36Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-13T00:49:36Z

src/test/tests_common.h

@@ -44,6 +44,7 @@
 #include <cart/api.h>

 #include "crt_internal.h"
+volatile int	 myflag = 0;


(style) do not initialise globals to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt

daosbuild1 · 2019-12-13T00:49:36Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-13T00:49:36Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-13T00:49:40Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/5/execution/node/44/log

daosbuild1 · 2019-12-13T01:09:33Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/5/execution/node/266/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/6/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-16T18:41:17Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-16T18:41:17Z

src/cart/crt_init.c

@@ -545,8 +545,8 @@ crt_finalize(void)
 		crt_gdata.cg_inited = 0;
 		gdata_init_flag = 0;

-		if (crt_gdata.cg_na_plugin == CRT_NA_OFI_SOCKETS)
-			crt_na_ofi_config_fini();
+//		if (crt_gdata.cg_na_plugin == CRT_NA_OFI_SOCKETS)


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T18:41:18Z

src/test/tests_common.h

@@ -44,6 +44,7 @@
 #include <cart/api.h>

 #include "crt_internal.h"
+volatile int	 myflag = 0;


(style) do not initialise globals to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt

daosbuild1 · 2019-12-16T18:41:18Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T18:41:18Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T18:41:23Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/6/execution/node/44/log

daosbuild1 · 2019-12-16T19:02:17Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/6/execution/node/275/log

let psm2 use ip:port addr format and use nameserver to resolve it to the psm2 native addr. This patch is based off the cart commit used by daos master as of 2019-12-11. note: 1) orterun needs to use this flag: --mca mtl ^psm2,ofi 2) server side needs to pass this shell variable under orterun: -x FI_PSM2_NAME_SERVER=1 this variable tells psm2 to start the name server 3) optionally, a OFI_PORT variable can be specified on either the server side or client side. If OFI_PORT is not specified, cart will pick a unused port on its own. 4) to make a server use the same address across restarts, supply this variable when launching the server: -x OFI_PORT=xxx Signed-off-by: Yulu Jia <yulu.jia@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-307/7/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-12-16T23:10:13Z

src/crt_launch/crt_launch.c

@@ -85,6 +85,7 @@ struct host {
 };

 static int	my_rank;
+volatile static int	myflag = 0;


(style) do not initialise statics to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
(style) storage class should be at the beginning of the declaration

daosbuild1 · 2019-12-16T23:10:14Z

src/cart/crt_init.c

@@ -545,8 +545,8 @@ crt_finalize(void)
 		crt_gdata.cg_inited = 0;
 		gdata_init_flag = 0;

-		if (crt_gdata.cg_na_plugin == CRT_NA_OFI_SOCKETS)
-			crt_na_ofi_config_fini();
+//		if (crt_gdata.cg_na_plugin == CRT_NA_OFI_SOCKETS)


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T23:10:14Z

src/test/tests_common.h

@@ -44,6 +44,7 @@
 #include <cart/api.h>

 #include "crt_internal.h"
+volatile int	 myflag = 0;


(style) do not initialise globals to 0
(style) Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt

daosbuild1 · 2019-12-16T23:10:14Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T23:10:14Z

src/cart/crt_hg.c


 		D_ASPRINTF(*string, "%s://%s/%s:%d", plugin_str,
 			crt_na_ofi_conf.noc_domain,
 			crt_na_ofi_conf.noc_ip_str, port);
+//		D_ASPRINTF(*string, "%s://%s:%d", plugin_str,
+//			crt_na_ofi_conf.noc_ip_str, port);


(style) do not use C99 // comments

daosbuild1 · 2019-12-16T23:10:20Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/7/execution/node/44/log

daosbuild1 · 2019-12-16T23:30:41Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-307/7/execution/node/239/log

daosbuild1 previously requested changes Dec 12, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from 2509889 to 38749b1 Compare December 12, 2019 20:27

daosbuild1 previously requested changes Dec 12, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from 38749b1 to 48f7d46 Compare December 12, 2019 21:43

daosbuild1 previously requested changes Dec 12, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from 48f7d46 to 10f0146 Compare December 12, 2019 22:16

daosbuild1 previously requested changes Dec 12, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from 10f0146 to aa6d98c Compare December 13, 2019 00:48

daosbuild1 previously requested changes Dec 13, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from aa6d98c to 3d96f55 Compare December 16, 2019 18:34

daosbuild1 previously requested changes Dec 16, 2019

View reviewed changes

yulujia force-pushed the enable-psm2-nameserver-wip branch from 3d96f55 to a6ea906 Compare December 16, 2019 23:09

daosbuild1 suggested changes Dec 16, 2019

View reviewed changes

enable psm2 nameserver #307

Are you sure you want to change the base?

enable psm2 nameserver #307

Conversation

yulujia commented Dec 12, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2019

daosbuild1 commented Dec 12, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2019

daosbuild1 commented Dec 12, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2019

daosbuild1 commented Dec 12, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2019

daosbuild1 commented Dec 12, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 13, 2019

daosbuild1 commented Dec 13, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 16, 2019

daosbuild1 commented Dec 16, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 16, 2019

daosbuild1 commented Dec 16, 2019