CORCI-261: build: Global product versioning (#7) #1017

brianjmurrell · 2019-08-28T16:54:56Z

Add a VERSION file for all things that want to display a version
to be able to read from.

Add an scons target "release" that takes a RELEASE variable to create
a new release from. This updates:

the VERSION file
the RPM daos.spec
and then commits the changes.

Get the version of the libdaos library to import from the VERSION file.

Once a PR with an updated VERSION file lands to master, a GitHub
action will create a release on GitHub which will include creating a
tag on master where the PR was landed.

Signed-off-by: Brian J. Murrell brian.murrell@intel.com

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:97:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:203:
(pylint-pointless-string-statement) String statement has no effect

src/utils/py/daos_api.py

.github/actions/make_release/entrypoint.sh

SConstruct

daosbuild1 · 2019-08-28T17:05:49Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/47/log

daosbuild1 · 2019-08-28T17:09:41Z

Test stage Build RPM on CentOS 7 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/173/log

daosbuild1 · 2019-08-28T17:11:24Z

Test stage Build RPM on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/255/log

daosbuild1 · 2019-08-28T17:37:32Z

Test stage Build on Leap 42.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/223/log

daosbuild1 · 2019-08-28T17:37:38Z

Test stage Build on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/225/log

daosbuild1 · 2019-08-28T17:43:35Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/224/log

daosbuild1 · 2019-08-28T17:46:28Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/216/log

daosbuild1 · 2019-08-28T17:46:43Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/1/execution/node/283/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:97:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:203:
(pylint-pointless-string-statement) String statement has no effect

src/utils/py/daos_api.py

.github/actions/make_release/entrypoint.sh

SConstruct

daosbuild1 · 2019-08-28T18:09:45Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/2/execution/node/47/log

daosbuild1 · 2019-08-28T18:19:14Z

Test stage Build RPM on CentOS 7 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/2/execution/node/213/log

daosbuild1 · 2019-08-28T18:23:43Z

Test stage Build RPM on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/2/execution/node/243/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:205:
(pylint-pointless-string-statement) String statement has no effect

src/utils/py/daos_api.py

SConstruct

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:205:
(pylint-pointless-string-statement) String statement has no effect

src/utils/py/daos_api.py

SConstruct

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:210:
(pylint-pointless-string-statement) String statement has no effect

SConstruct

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/6/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:210:
(pylint-pointless-string-statement) String statement has no effect

SConstruct

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/7/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:210:
(pylint-pointless-string-statement) String statement has no effect

SConstruct

daosbuild1 · 2019-08-29T01:18:19Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/7/execution/node/47/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/9/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:217:
(pylint-pointless-string-statement) String statement has no effect

daosbuild1 · 2019-08-29T14:22:23Z

SConstruct

+                        callbacks=MyCallbacks())
+        except pygit2.GitError:
+            print("Error pushing branch.  Does it exist in GitHub already?\n"
+                 "See https://github.com/{}/daos/branches".format(org_name))


(pylint-bad-continuation) Wrong continued indentation (add 1 space).

daosbuild1 · 2019-08-29T14:22:32Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/9/execution/node/48/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/10/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (31/30)

SConstruct:220:
(pylint-pointless-string-statement) String statement has no effect

daosbuild1 · 2019-08-29T15:30:22Z

SConstruct

+                        callbacks=MyCallbacks())
+        except pygit2.GitError:
+            print("Error pushing branch.  Does it exist in GitHub already?\n"
+                 "See https://github.com/{}/daos/branches".format(org_name))


(pylint-bad-continuation) Wrong continued indentation (add 1 space).

SConstruct

daosbuild1 · 2019-08-29T15:30:26Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/10/execution/node/48/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-1017/11/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

SConstruct:96:
(pylint-missing-docstring) Missing function docstring
(pylint-too-many-locals) Too many local variables (33/30)

SConstruct:236:
(pylint-pointless-string-statement) String statement has no effect

SConstruct

daosbuild1 · 2019-08-29T16:36:25Z

SConstruct

+            'refs/remotes/{}/master'.format(remote_name))
+        try:
+            repo.branches.create(branch, repo[master.target])
+        except pygit2.AlreadyExistsError:


(pylint-no-member) Module 'pygit2' has no 'AlreadyExistsError' member

daosbuild1 · 2019-08-29T16:36:25Z

SConstruct

+            repo.branches.create(branch, repo[master.target])
+        except pygit2.AlreadyExistsError:
+            print("Branch {} exists in GitHub already\n"
+                 "See https://github.com/{}/daos/branches".format(branch,


(pylint-bad-continuation) Wrong continued indentation (add 1 space).

daosbuild1 · 2019-08-29T16:36:25Z

SConstruct

+                        callbacks=MyCallbacks())
+        except pygit2.GitError:
+            print("Error pushing branch.  Does it exist in GitHub already?\n"
+                 "See https://github.com/{}/daos/branches".format(org_name))


(pylint-bad-continuation) Wrong continued indentation (add 1 space).

daosbuild1 · 2019-08-29T16:36:25Z

SConstruct

+
+        print("Self-assigning the PR...")
+        # self-assign the PR
+        me = gh_context.get_user(gh_context.get_user().login)


(pylint-invalid-name) Invalid variable name "me"

daosbuild1 · 2019-08-29T16:36:30Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1017/11/execution/node/48/log

Add a VERSION file for all things that want to display a version to be able to read from. Add an scons target "release" that takes a RELEASE variable to create a new release from. This updates: - the VERSION file - the RPM daos.spec and then commits the changes. Get the version of the libdaos library to import from the VERSION file. Once a PR with an updated VERSION file lands to master, a GitHub action will create a release on GitHub which will include creating a tag on master where the PR was landed. Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

Updated patch

jolivier23

seems reasonable, I think. I presume this doesn't generate any new files that would need to be cleaned?

brianjmurrell · 2019-09-04T15:39:26Z

seems reasonable, I think.

😄

I presume this doesn't generate any new files that would need to be cleaned?

The only new file created is the VERSION file and that gets committed to git in the process.

daosbuild1 previously requested changes Aug 28, 2019

View reviewed changes

src/utils/py/daos_api.py Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Show resolved Hide resolved

daosbuild1 previously requested changes Aug 28, 2019

View reviewed changes

src/utils/py/daos_api.py Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Show resolved Hide resolved

daosbuild1 previously requested changes Aug 28, 2019

View reviewed changes

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

SConstruct Outdated Show resolved Hide resolved

daosbuild1 previously requested changes Aug 28, 2019

View reviewed changes

SConstruct Outdated Show resolved Hide resolved

daosbuild1 previously requested changes Aug 29, 2019

View reviewed changes

SConstruct Outdated Show resolved Hide resolved

brianjmurrell force-pushed the create_release branch from 47d6a26 to f8ac975 Compare August 29, 2019 12:50

brianjmurrell force-pushed the create_release branch from f8ac975 to 32c4d78 Compare August 29, 2019 14:18

daosbuild1 previously requested changes Aug 29, 2019

View reviewed changes

brianjmurrell force-pushed the create_release branch from 32c4d78 to 3498153 Compare August 29, 2019 15:26

daosbuild1 previously requested changes Aug 29, 2019

View reviewed changes

brianjmurrell force-pushed the create_release branch from 3498153 to f99c52c Compare August 29, 2019 16:32

brianjmurrell requested a review from jolivier23 August 29, 2019 16:33

daosbuild1 previously requested changes Aug 29, 2019

View reviewed changes

brianjmurrell force-pushed the create_release branch from f99c52c to 612b3c6 Compare August 29, 2019 17:02

jolivier23 approved these changes Sep 3, 2019

View reviewed changes

brianjmurrell requested a review from JohnMalmberg September 4, 2019 15:39

brianjmurrell mentioned this pull request Sep 4, 2019

CORCI-261: build: Global product versioning #940

Closed

JohnMalmberg approved these changes Sep 10, 2019

View reviewed changes

brianjmurrell requested a review from a team September 10, 2019 17:41

jolivier23 merged commit 055a30f into master Sep 10, 2019

jolivier23 deleted the create_release branch September 10, 2019 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CORCI-261: build: Global product versioning (#7) #1017

CORCI-261: build: Global product versioning (#7) #1017

brianjmurrell commented Aug 28, 2019

daosbuild1 left a comment

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 left a comment

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

daosbuild1 Aug 29, 2019

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

daosbuild1 Aug 29, 2019

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

daosbuild1 Aug 29, 2019

daosbuild1 Aug 29, 2019

daosbuild1 Aug 29, 2019

daosbuild1 Aug 29, 2019

daosbuild1 commented Aug 29, 2019

jolivier23 left a comment

brianjmurrell commented Sep 4, 2019

CORCI-261: build: Global product versioning (#7) #1017

CORCI-261: build: Global product versioning (#7) #1017

Conversation

brianjmurrell commented Aug 28, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 commented Aug 28, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 commented Aug 29, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 Aug 29, 2019

Choose a reason for hiding this comment

daosbuild1 commented Aug 29, 2019

jolivier23 left a comment

Choose a reason for hiding this comment

brianjmurrell commented Sep 4, 2019