Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15136 client: Switch to using libfused #14077

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

DAOS-15136 client: Switch to using libfused #14077

wants to merge 26 commits into from
+45 −62

Conversation

jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented Mar 28, 2024 •
edited
Loading

Switch to using libfused instead of libfuse3

This enables the following:

  1. customization of libfuse for dfuse use case
  2. Ability to release the library without breaking other fuse users.

fused is a fork of libfuse that renames
the library and header file directory.

Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Ticket title is 'we build a libfuse rpm but there is no matching developer build'
Status is 'In Progress'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-15136

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/354/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/327/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/287/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/351/log

@jolivier23 jolivier23 force-pushed the jvolivie/fused branch 2 times, most recently from 825db6d to 3105249 Compare March 28, 2024 01:27
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/341/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/369/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/353/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/270/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/309/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/355/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/287/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/364/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/350/log

@jolivier23
DAOS-15136 client: Switch to using libfused
df7aadc 
Switch to using libfused instead of libfuse3

PR-repos: fused@PR-1:28

Required-githooks: true

Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge branch 'master' into jvolivie/fused
7bf9fb8 
Required-githooks: true

Change-Id: Iddf5882e12161746511e598b3cb4ae380af35683
@jolivier23
PR-repos: fused@1:28
20bf3b6 
Required-githooks: true

Change-Id: Icdd7235f8a93363ee7cc33a1adb5e3c43956c4aa
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/326/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/345/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/329/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/338/log

@jolivier23
Fix a few more issues
a397c1e 
Required-githooks: true

Features: dfuse

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Copy link
Contributor Author

I started looking at static compilation and it wasn't trivial (no debian packages in daos-stack/fused, for example) so I thought I would try to finish this.

fused is currently in sync with libfuse head so need some validation but it has all of the patches. I changed tactics to just do a few renames from fuse3 to fused which hopefully won't cause too many future conflicts when syncing.

@jolivier23
Features: dfuse
dc5d340 
Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Clean up rpm dependencies
85041ed 
Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
empty commit for test
0ed4c7c 
Features: dfuse
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Add back valgrind testing
4b266cf 
Features: dfuse
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
fix typo
3f3a397 
Allow-unstable-test: true
Features: dfuse

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/20/execution/node/817/log

@jolivier23
Try again
515b136 
Allow-unstable-test: true
Features: dfuse

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14077/21/testReport/

@jolivier23
Add missing FUSE_CAP for printing
7585023 
Allow-unstable-test: true
Features: dfuse

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge branch 'master' into jvolivie/fused
45a2e77 
Features: dfuse
Allow-unstable-test: true
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14077/23/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/23/execution/node/1425/log

@jolivier23
Merge branch 'master' into jvolivie/fused
c1082d5 
Allow-unstable-test: true
Features: dfuse
@jolivier23
Merge branch 'master' into jvolivie/fused
7ba97a2
@jolivier23
Merge master again now that jenkins is back
6fd013c 
Allow-unstable-test: true
Features: dfuse

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 marked this pull request as ready for review December 27, 2024 15:56
@jolivier23 jolivier23 requested review from a team as code owners December 27, 2024 15:56
@jolivier23
Copy link
Contributor Author

jolivier23 commented Dec 27, 2024 •
edited
Loading

Looks like it hit this warning: https://daosio.atlassian.net/browse/DAOS-16869 with NLT

No other failures with Features: dfuse

@jolivier23 jolivier23 requested review from wangdi1 and removed request for ashleypittman December 27, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleypittman ashleypittman ashleypittman left review comments

@brianjmurrell brianjmurrell brianjmurrell left review comments

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

@wangdi1 wangdi1 Awaiting requested review from wangdi1

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolivier23 @daosbuild1 @brianjmurrell @ashleypittman