Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16263 cq: merge yamllint and clang-format into linting #14803

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

daltonbohning
Copy link
Contributor

merge yamllint and clang-format into linting workflow so all lint checks are grouped together.

Skip-test: true
Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jul 22, 2024
Copy link

Ticket title is 'gha: merge clang-format and yaml lint into Linting workflow'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16263

.github/workflows/linting.yml Dismissed Show dismissed Hide dismissed
.github/workflows/linting.yml Dismissed Show dismissed Hide dismissed
runs-on: ubuntu-22.04
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: GitHub-owned GitHubAction not pinned by hash
Click Remediation section below to solve this issue
with:
target: origin/${{ github.event.pull_request.base.ref }}
- name: Export changes
uses: actions/upload-artifact@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: GitHub-owned GitHubAction not pinned by hash
Click Remediation section below to solve this issue
.github/workflows/linting.yml Dismissed Show dismissed Hide dismissed
@daltonbohning daltonbohning force-pushed the dbohning/daos-16263 branch 2 times, most recently from 0d80de0 to a046094 Compare July 22, 2024 20:03
merge yamllint and clang-format into linting workflow so all lint checks
are grouped together.

Make yaml-lint required but clang-format optional until stable.

Skip-test: true
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review July 22, 2024 20:48
@daltonbohning daltonbohning requested a review from a team July 24, 2024 21:47
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 24, 2024
@phender phender merged commit 6fffd11 into master Jul 24, 2024
36 checks passed
@phender phender deleted the dbohning/daos-16263 branch July 24, 2024 21:47
daltonbohning added a commit that referenced this pull request Dec 18, 2024
merge yamllint and clang-format into linting workflow so all lint checks
are grouped together.

Make yaml-lint required but clang-format optional until stable.

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning added a commit that referenced this pull request Dec 20, 2024
…15642)

merge yamllint and clang-format into linting workflow so all lint checks
are grouped together.

Make yaml-lint required but clang-format optional until stable.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

3 participants