Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16478 test: pool/autotest.py - Increase timeout #15102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shimizukko
Copy link
Contributor

The two tests in autotest.py with MD-on-SSD timed out in build 248. This was potentially caused by the slow TCP provider. Build 248 was the only timed out instance in the past 20 builds (235 to 255), so it looks like an intermittent issue. Increase the timeout by 50% and run it 10 times and check that it doesn't time out.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_pool_autotest
Test-repeat: 10

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

The two tests in autotest.py with MD-on-SSD timed out in build
248. This was potentially caused by the slow TCP provider.
Build 248 was the only timed out instance in the past 20 builds
(235 to 255), so it looks like an intermittent issue. Increase
the timeout by 50% and run it 10 times and check that it doesn't
time out.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_pool_autotest
Test-repeat: 10

Signed-off-by: Makito Kano <makito.kano@intel.com>
Copy link

github-actions bot commented Sep 9, 2024

Ticket title is 'pool/autotest.py:PoolAutotestTest.test_pool_autotest - daos pool autotest timeout'
Status is 'In Progress'
Labels: '2.6.1rc1,2.6.1rc2,2.6.1rc3,ci_master_daily,daily_test,md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16478

@shimizukko shimizukko marked this pull request as ready for review September 9, 2024 20:40
@shimizukko shimizukko requested review from a team as code owners September 9, 2024 20:40
@shimizukko
Copy link
Contributor Author

I noticed that MD-on-SSD test didn't use TCP provider (used ofi+verbs;ofi_rxm)

@daltonbohning
Copy link
Contributor

I think the original issue might have been https://daosio.atlassian.net/browse/DAOS-16484, since the original failure was using eth0 instead of ib0

@shimizukko
Copy link
Contributor Author

I think the original issue might have been https://daosio.atlassian.net/browse/DAOS-16484, since the original failure was using eth0 instead of ib0

I see. If the test isn't expected to run on TCP/eth0, then we can close this PR.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Test-tag: test_pool_autotest
Test-repeat: 2
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag-hw-medium-ucx-provider: test_pool_autotest
Test-repeat: 2
@shimizukko
Copy link
Contributor Author

It sounds like the timeout occurred with the slow TCP provider. However, to run the test with TCP provider with MD-on-SSD in CI, the test needs to use wolf-[122-125], but there's no way to request specific hosts with test tag, etc. The test run logs are gone, so I can't tell the exact provider and interface used.

A month after the ticket was created, timeout occurred with UCX provider. Currently I'm trying to run the test with UCX provider using test tag such as Test-tag-hw-medium-ucx-provider: test_pool_autotest.

https://daosio.atlassian.net/browse/DAOS-16484: This issue is about selecting the slower interface (eth0 instead of ib0), but even after it's fixed, timeout occurred with UCX provider with ib0, so fixing the interface selection issue doesn't automatically solve the autotest.py timeout issue and we probably need to increase the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants