-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16374 vos: integer overflow on evt recx trace #15439
Conversation
The evt recx trace is used for vos aggregation debugging, and it's currently reset on akey iteration callback, but the akey iteration callback could be skipped in some cases, for example, when evt aggregation hit an aborted recx, it'll start over in evtree level without the recx trace reset, that could lead to integer overflow on the 'int ap_trace_count'. This patch moved the ap_trace_count reset to merge window open/close to ensure the evt recx trace always being reset properly. Required-githooks: true Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Ticket title is 'control/config_generate_output.py and control/config_generate_run.py tests are failing to start the daos servers with sudo command.' |
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15439/1/display/redirect |
Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15439/1/testReport/ |
The evt recx trace is used for vos aggregation debugging, and it's currently reset on akey iteration callback, but the akey iteration callback could be skipped in some cases, for example, when evt aggregation hit an aborted recx, it'll start over in evtree level without the recx trace reset, that could lead to integer overflow on the 'int ap_trace_count'. This patch moved the ap_trace_count reset to merge window open/close to ensure the evt recx trace always being reset properly. Signed-off-by: Niu Yawei <yawei.niu@intel.com>
The evt recx trace is used for vos aggregation debugging, and it's currently reset on akey iteration callback, but the akey iteration callback could be skipped in some cases, for example, when evt aggregation hit an aborted recx, it'll start over in evtree level without the recx trace reset, that could lead to integer overflow on the 'int ap_trace_count'. This patch moved the ap_trace_count reset to merge window open/close to ensure the evt recx trace always being reset properly. Signed-off-by: Niu Yawei <yawei.niu@intel.com> Co-authored-by: Niu Yawei <yawei.niu@intel.com>
The evt recx trace is used for vos aggregation debugging, and it's currently reset on akey iteration callback, but the akey iteration callback could be skipped in some cases, for example, when evt aggregation hit an aborted recx, it'll start over in evtree level without the recx trace reset, that could lead to integer overflow on the 'int ap_trace_count'.
This patch moved the ap_trace_count reset to merge window open/close to ensure the evt recx trace always being reset properly.
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: