Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16477 mgmt: return suspect engines for pool healthy query (#15458) #15512

Merged
merged 1 commit into from
Jan 9, 2025
Merged

DAOS-16477 mgmt: return suspect engines for pool healthy query (#15458) #15512

merged 1 commit into from
Jan 9, 2025

Conversation

wangshilong
Copy link
Contributor

  • DAOS-16477 mgmt: return suspect engines for pool healthy query

After significant failures, the system may leave behind some suspect engines that were marked as DEAD by the SWIM protocol, but were not excluded from the system to prevent data loss. An administrator can bring these ranks back online by restarting them.

This PR aims to provide an administrative interface for querying suspect engines following a massive failure. These suspect engines can be retrieved using the daos/dmg --health-only command.

An example of output of dmg pool query --health-only:

Pool 6f450a68-8c7d-4da9-8900-02691650f6a2, ntarget=8, disabled=2, leader=3, version=4, state=Degraded Pool health info:

  • Disabled ranks: 1
  • Suspect ranks: 2
  • Rebuild busy, 0 objs, 0 recs

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Ticket title is 'Provide admin interface to query hanging engines after massive failure'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16477

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Nov 18, 2024
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/1/testReport/

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from e646c43 to e8e6dd7 Compare November 20, 2024 08:58
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/2/testReport/

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from e8e6dd7 to e7a7d80 Compare November 21, 2024 15:07
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/3/testReport/

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from e7a7d80 to e415290 Compare November 22, 2024 00:51
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/4/testReport/

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from e415290 to 1c57dd0 Compare November 22, 2024 09:14
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15512/5/testReport/

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from 1c57dd0 to 0ef9e87 Compare November 22, 2024 14:48
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15512/6/execution/node/1131/log

@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch 2 times, most recently from 1f7ed6a to 67bee2d Compare November 25, 2024 07:33
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15512/8/execution/node/1098/log

@phender @wangshilong
DAOS-16477 mgmt: return suspect engines for pool healthy query (#15458)
95bdcdf 
* DAOS-16477 mgmt: return suspect engines for pool healthy query

After significant failures, the system may leave behind some suspect
engines that were marked as DEAD by the SWIM protocol, but were not
excluded from the system to prevent data loss. An administrator
can bring these ranks back online by restarting them.

This PR aims to provide an administrative interface for querying
suspect engines following a massive failure. These suspect engines
can be retrieved using the daos/dmg --health-only command.

An example of output of dmg pool query --health-only:

Pool 6f450a68-8c7d-4da9-8900-02691650f6a2, ntarget=8, disabled=2, leader=3, version=4, state=Degraded
Pool health info:
- Disabled ranks: 1
- Suspect ranks: 2
- Rebuild busy, 0 objs, 0 recs

Features: DmgPoolQueryRanks
skip-nlt: true
Required-githooks: true
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Co-authored-by: Phil Henderson <phillip.henderson@intel.com>
@wangshilong wangshilong force-pushed the shilongw/DAOS-16477-release-2.6 branch from 67bee2d to 95bdcdf Compare December 12, 2024 03:33
@wangshilong wangshilong marked this pull request as ready for review January 7, 2025 00:58
@wangshilong wangshilong requested review from a team as code owners January 7, 2025 00:58
@wangshilong wangshilong requested review from a team as code owners January 7, 2025 00:58
@wangshilong wangshilong requested review from liw and tanabarr January 7, 2025 00:58
@wangshilong
Copy link
Contributor Author

Port is for 2.6, reviewers please raise priority this...Thanks!!!!

liw
liw approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@liw liw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to backport a few other master commits related to "suspect"->"dead" and the documentation, is that right? One might want to use git log <path> to find out which.

@wangshilong
Copy link
Contributor Author

We'll need to backport a few other master commits related to "suspect"->"dead" and the documentation, is that right? One might want to use git log <path> to find out which.

Yes, we need backport another two PRs(one rename and one fix as I remeber)

knard38
knard38 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nice work which should be very helpful for support tasks :-)

src/pool/srv_cli.c
rc == -DER_NONEXIST ? -1 : state.sms_status);
if (rc == -DER_NONEXIST || state.sms_status == SWIM_MEMBER_DEAD) {
rc = d_rank_list_append(rank_list, doms[i].do_comp.co_rank);
if (rc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT from my understanding an assert could be more suited.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might fail because of out of memory, I suppose to return error here is better?

daltonbohning
daltonbohning reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@wangshilong wangshilong requested a review from a team January 8, 2025 01:19
@wangshilong
Copy link
Contributor Author

@daos-stack/daos-gatekeeper would you consider to force land this RP? thanks!

@wangshilong
Copy link
Contributor Author

@daos-stack/daos-gatekeeper would you consider to force land this RP? thanks!

Build/Run DAOS/NLT test failure looks a environment failure:
22 | RUN echo "APT::Install-Recommends "false";" > /etc/apt/apt.conf.d/no-recommends
23 | >>> RUN apt-get update &&
24 | >>> apt-get upgrade &&
25 | >>> chmod +x /tmp/install.sh &&
26 | >>> /tmp/install.sh &&
27 | >>> apt-get clean all
28 |

ERROR: failed to solve: process "/bin/sh -c apt-get update && apt-get upgrade && chmod +x /tmp/install.sh && /tmp/install.sh && apt-get clean all" did not complete successfully: exit code: 100

@mchaarawi mchaarawi merged commit 703a9fc into release/2.6 Jan 9, 2025
52 of 54 checks passed
@mchaarawi mchaarawi deleted the shilongw/DAOS-16477-release-2.6 branch January 9, 2025 14:45
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@knard38 knard38 knard38 approved these changes

@tanabarr tanabarr tanabarr approved these changes

@liw liw liw approved these changes

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wangshilong @daosbuild1 @liw @tanabarr @jolivier23 @daltonbohning @knard38 @mchaarawi