Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16732 client: version check in glibc libraries names #15549

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

wiliamhuang
Copy link
Contributor

Also use D_ASPRINTF instead of asprintf

Features: pil4dfs

Skip-func-test-el8: false
Skip-func-test-el9: false
Skip-func-test-leap15: false

Skip-func-vm-test-el8: false
Skip-func-vm-test-el9: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Also use D_ASPRINTF instead of asprintf

Features: pil4dfs

Skip-func-test-el8: false
Skip-func-test-el9: false
Skip-func-test-leap15: false

Skip-func-vm-test-el8: false
Skip-func-vm-test-el9: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Signed-off-by: Lei Huang <lei.huang@intel.com>
Copy link

github-actions bot commented Dec 2, 2024

Ticket title is 'EL9 dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_pil4df - Failure to build over dfuse with il in mode nocache'
Status is 'Resolved'
Labels: '2.7.101tb,ci_master_weekly,intercept_lib,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16732

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15549/3/testReport/

Features: pil4dfs

Skip-func-test-el8: false
Skip-func-test-el9: false
Skip-func-test-leap15: false

Skip-func-vm-test-el8: false
Skip-func-vm-test-el9: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Allow-unstable-test: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang
Copy link
Contributor Author

The failure in NLT on EL 8.8 / Valgrind.Valgrind_Memcheck is due to memory leak in go runtime library as reported in https://daosio.atlassian.net/browse/DAOS-16787.

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15549/4/testReport/

Features: pil4dfs

Skip-func-test-el8: false
Skip-func-test-el9: false
Skip-func-test-leap15: false

Skip-func-vm-test-el8: false
Skip-func-vm-test-el9: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Allow-unstable-test: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang wiliamhuang marked this pull request as ready for review January 6, 2025 22:08
@wiliamhuang wiliamhuang requested review from a team as code owners January 6, 2025 22:08
@wiliamhuang wiliamhuang requested a review from a team January 7, 2025 14:20
@wiliamhuang
Copy link
Contributor Author

@daos-stack/daos-gatekeeper Can we land this PR? Thank you!

@daltonbohning
Copy link
Contributor

@daos-stack/daos-gatekeeper Can we land this PR? Thank you!

I think the ticket needs merge approval

@mchaarawi mchaarawi merged commit cbe65ce into release/2.6 Jan 9, 2025
57 of 58 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-16732_2.6 branch January 9, 2025 15:58
@mchaarawi
Copy link
Contributor

@daos-stack/daos-gatekeeper Can we land this PR? Thank you!

I think the ticket needs merge approval

oops.. for some reason I thought i saw this request in merge approvals.

@wiliamhuang
Copy link
Contributor Author

@daos-stack/daos-gatekeeper Can we land this PR? Thank you!

I think the ticket needs merge approval

A couple of tickets are related. This PR got backport approval in ticket https://daosio.atlassian.net/browse/DAOS-16792.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants