Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16500 build: Move to Leap 15.6 #15561

Merged
merged 9 commits into from
Dec 21, 2024
Merged

DAOS-16500 build: Move to Leap 15.6 #15561

merged 9 commits into from
Dec 21, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Dec 4, 2024

Build and test with Leap 15.6 instead of Leap 15.5.

Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16500 build: Move to Leap 15.6
f895d44 
Build and test with Leap 15.6 instead of Leap 15.5.

Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from a team as a code owner December 4, 2024 16:55
@phender phender requested a review from brianjmurrell December 4, 2024 16:55
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/347/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/350/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/384/log

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Ticket title is 'DAOS 2.6.2 SLES 15 SP6 support'
Status is 'In Review'
Labels: 'lrz,testp1'
https://daosio.atlassian.net/browse/DAOS-16500

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/273/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.6 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/524/log

brianjmurrell
brianjmurrell requested changes Dec 4, 2024
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
ci/parse_ci_envs.sh Outdated Show resolved Hide resolved
utils/rpms/packaging/Makefile_distro_vars.mk Outdated Show resolved Hide resolved
@phender
Applying feedback.
5feb645 
Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from brianjmurrell December 4, 2024 22:47
brianjmurrell
brianjmurrell previously approved these changes Dec 10, 2024
View reviewed changes
Jenkinsfile Outdated
@@ -1081,7 +1082,7 @@ pipeline {
rpm_test_post(env.STAGE_NAME, env.NODELIST)
}
}
} // stage('Test CentOS 7 RPMs')
} // stage('Test RPMs on EL 8.6')
stage('Test RPMs on Leap 15.4') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still want to be testing on Leap 15.4 here, or should this be 15.5 with this move to 15.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal here is to run this test on the N-1 version, then I should. Is that the intention of this stage?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally yes-ish. The ultimate goal is to run this stage on any other version of a distro that is supported for a release. Generally that is only n-1 if even that. For Leap, I think we tend to be less willing to support n and n-1 but for EL, we do tend to be more willing to do that.

Which versions we support in a release is supposed to be tracked in SRS tickets such as this one for the 2.8 Community Release. That ticket unfortunately seems to be incomplete at this time.

The SRS ticket for the 2.6 Community Release though is a more complete example. You can see that it only specifies Leap 15.5. That would/should be why that stage is generally skipped such as you can see here. That should be driven by the value of the CI_RPMS_leap15.4_TEST parameter in the Jenkinsfile but I see that that parameter is actually currently missing.

Similarly, the Test RPMs on EL 8.6 stage (it should actually be 8.8 with main functional testing on 8.10 -- clearly things have slipped in that regard) is being run because SRS-407 says we are covering two releases for EL8.

I am at a loss however to explain why that Test RPMs on EL 8.6 stage is being run as the Jenkinsfile is also missing the CI_RPMS_el8.6_TEST that the stage skip code for that stage wants: https://github.com/daos-stack/pipeline-lib/blob/e6831a2ec6c8b9ee4ada79cd50aa91332fd98993/vars/skipStage.groovy#L489-L501.

In any case, that's how it's all supposed to work.

@phender
Merge branch 'master' into pahender/DAOS-16500
67ce6e8 
Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender
Merge branch 'master' into pahender/DAOS-16500
82543f4 
Skip-func-hw-test: true
Skip-func-test-leap15: false

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender
Update Test RPMs on Leap version to n-1.
46e15c2 
Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
phender
phender commented Dec 17, 2024
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
brianjmurrell
brianjmurrell previously approved these changes Dec 17, 2024
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/4/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/5/display/redirect

@phender
Fix daos-client-tests requirement on Leap.
a90db9b 
Skip-unit-tests: true
Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/6/execution/node/371/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/6/execution/node/354/log

@phender
Ignore rpmlint for libprotobuf-c-devel.
3e5bb5e 
Skip-unit-tests: true
Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/7/execution/node/871/log

@phender
Remove pipeline-lib ref.
f55809e 
Skip-unit-tests: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el8: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender phender requested a review from ryon-jensen December 19, 2024 20:27
@phender
Copy link
Contributor Author

phender commented Dec 19, 2024

The Functional on Leap 15.6 stage passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7 and the tests confirmed they ran on Leap 15.6. The pipeline-lib changes to support Leap 15.6 have been landed in daos-stack/pipeline-lib#450. So this is ready for final review.

daltonbohning
daltonbohning reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

@phender
Copy link
Contributor Author

phender commented Dec 19, 2024 •
edited
Loading

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677. We can build the RPMs on 15.5 and install them and test on 15.6. When the opensuse-leap-15.6-x86_64.cfg mock.cfg file is available I can update the Jenkinsfile to build on 15.6.

@daltonbohning
Copy link
Contributor

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677

So it seems we are building RPMs on Leap 15.5, then installing those lp155 on 15.6, right?
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7/artifact/Functional%20on%20Leap%2015.6/launch/functional_on_leap_15.6/details.json

Then when that comment is resolved, we'll build lp156?

@phender
Copy link
Contributor Author

phender commented Dec 19, 2024

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677

So it seems we are building RPMs on Leap 15.5, then installing those lp155 on 15.6, right? https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7/artifact/Functional%20on%20Leap%2015.6/launch/functional_on_leap_15.6/details.json

Then when that comment is resolved, we'll build lp156?

Correct.

@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/8/execution/node/821/log

@phender
Merge branch 'master' into pahender/DAOS-16500
719ff08 
Skip-unit-tests: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el8: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
@phender
Copy link
Contributor Author

phender commented Dec 21, 2024

All Functional on Leap 15.6 tests passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/view/change-requests/job/PR-15561/10/testReport/

@phender phender merged commit 8984dd6 into master Dec 21, 2024
68 checks passed
@phender phender deleted the pahender/DAOS-16500 branch December 21, 2024 04:06
phender added a commit that referenced this pull request Dec 21, 2024
@phender
DAOS-16500 build: Move to Leap 15.6 (#15561)
76d9269 
Test with Leap 15.6 instead of Leap 15.5.

Skip-unit-tests: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el8: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryon-jensen ryon-jensen ryon-jensen approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@brianjmurrell brianjmurrell brianjmurrell left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phender @daosbuild1 @daltonbohning @brianjmurrell @ryon-jensen