Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13292 build: Don't need UCX libraries … (#15016) #15623

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Dec 16, 2024

At build time any more, as of e01970d.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

At build time any more, as of e01970d.

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Copy link

Ticket title is 'Update control plane fabric scans to use new mercury API'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13292

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 16, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15623/1/testReport/

@kjacque kjacque marked this pull request as ready for review December 16, 2024 23:20
@kjacque kjacque requested review from a team as code owners December 16, 2024 23:20
@kjacque
Copy link
Contributor Author

kjacque commented Dec 16, 2024

These are build changes only.

Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove utils/build.config and other stuff ? Maybe I asked this on the master PR as well but don't recall

@daltonbohning
Copy link
Contributor

Remove utils/build.config and other stuff ? Maybe I asked this on the master PR as well but don't recall

It's a little misleading. It's just removing UCX from the RPM dependency, but source builds still require and build UCX

@@ -15,7 +15,7 @@

Name: daos
Version: 2.6.2
Release: 2%{?relval}%{?dist}
Release: 3%{?relval}%{?dist}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, oops. c631702 did not bump the Release (sorry, I merged that). So this should be 4 to be inline with the changelog comments. I guess we'll just skip 3. @brianjmurrell Does that sound reasonable? Or should we keep the Release: 3 and update the changelogs to be duplicated with 3 as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, skip 3 here but leave it in the changelog(s). As usual, keep the debian/changelog and the daos.spec in parity though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianjmurrell. I went ahead and pushed that @kjacque

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15623/2/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Dec 18, 2024

There is a known NLT valgrind issue on the 2.6 branch that caused the failures. All other tests passed for this PR. Requesting forced landing.

@kjacque kjacque self-assigned this Dec 18, 2024
@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 18, 2024
@kjacque kjacque requested a review from a team December 18, 2024 16:54
@daltonbohning daltonbohning merged commit baa6a87 into release/2.6 Dec 18, 2024
53 of 57 checks passed
@daltonbohning daltonbohning deleted the kjacque/2.6/remove-ucx-deps branch December 18, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

5 participants