-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13292 build: Don't need UCX libraries … (#15016) #15623
Conversation
At build time any more, as of e01970d. Required-githooks: true Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Ticket title is 'Update control plane fabric scans to use new mercury API' |
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15623/1/testReport/ |
These are build changes only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove utils/build.config and other stuff ? Maybe I asked this on the master PR as well but don't recall
It's a little misleading. It's just removing UCX from the RPM dependency, but source builds still require and build UCX |
utils/rpms/daos.spec
Outdated
@@ -15,7 +15,7 @@ | |||
|
|||
Name: daos | |||
Version: 2.6.2 | |||
Release: 2%{?relval}%{?dist} | |||
Release: 3%{?relval}%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, oops. c631702 did not bump the Release
(sorry, I merged that). So this should be 4
to be inline with the changelog comments. I guess we'll just skip 3
. @brianjmurrell Does that sound reasonable? Or should we keep the Release: 3
and update the changelogs to be duplicated with 3
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, skip 3 here but leave it in the changelog(s). As usual, keep the debian/changelog
and the daos.spec
in parity though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brianjmurrell. I went ahead and pushed that @kjacque
Required-githooks: true Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15623/2/testReport/ |
There is a known NLT valgrind issue on the 2.6 branch that caused the failures. All other tests passed for this PR. Requesting forced landing. |
At build time any more, as of e01970d.
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: