Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16889 build: fix finding protobuf #15625

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

daltonbohning
Copy link
Contributor

Add a requirement to protobufc for building daos control binaries.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Add a requirement to protobufc for building daos control binaries.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning self-assigned this Dec 16, 2024
Copy link

Ticket title is 'build fails to find protobuf-c/protobuf-c.h even though it is installed'
Status is 'In Progress'
Labels: 'TACC_Frontera'
https://daosio.atlassian.net/browse/DAOS-16889

@daltonbohning daltonbohning marked this pull request as ready for review December 17, 2024 16:16
@daltonbohning daltonbohning requested review from a team as code owners December 17, 2024 16:16
@daltonbohning
Copy link
Contributor Author

@mchaarawi FYI This fixes the issue with finding protobuf that you mentioned internally before. I think most people just installed the RPMs, but technically that shouldn't be necessary because scons was already builing protobuf

@jolivier23 jolivier23 merged commit b31f634 into master Dec 17, 2024
58 checks passed
@jolivier23 jolivier23 deleted the dbohning/frontera-fix branch December 17, 2024 16:39
daltonbohning added a commit that referenced this pull request Dec 18, 2024
Add a requirement to protobufc for building daos control binaries.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Dec 18, 2024
Add a requirement to protobufc for building daos control binaries.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning added a commit that referenced this pull request Dec 19, 2024
Add a requirement to protobufc for building daos control binaries.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants