Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16787 utils: Suppress NLT valgrind false positives (#15478) #15637

Merged
merged 1 commit into from
Dec 18, 2024
Merged

DAOS-16787 utils: Suppress NLT valgrind false positives (#15478) #15637

merged 1 commit into from
Dec 18, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Dec 17, 2024 •
edited
Loading

  • Add a suppression for Go runtime function racefuncenter.
  • Add suppression for rt0_go CGo malloc

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-16787 utils: Suppress NLT valgrind false positives (#15478)
d93f8c2 
* Add a suppression for Go runtime function racefuncenter.
* Add suppression for rt0_go CGo malloc

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 17, 2024
@kjacque kjacque self-assigned this Dec 17, 2024
@kjacque kjacque requested review from a team as code owners December 17, 2024 23:46
@github-actions GitHub Actions
Copy link

Ticket title is 'NLT on EL 8.8 / Valgrind.Valgrind_Memcheck - Valgrind Memcheck error detected'
Status is 'Awaiting backport'
Labels: '2.6.2tb1,2.7.101tb,NLT-testing'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16787

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 17, 2024
@kjacque
Copy link
Contributor Author

kjacque commented Dec 17, 2024

No extra tests needed. This affects the NLT memcheck stage only.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15637/1/execution/node/1565/log

@kjacque
Copy link
Contributor Author

kjacque commented Dec 18, 2024

NLT passed even though a daos_test test failed. This change has no impact on anything outside of NLT. Requesting forced-landing.

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 18, 2024
@kjacque kjacque requested a review from a team December 18, 2024 16:51
@daltonbohning daltonbohning merged commit 79bf081 into release/2.6 Dec 18, 2024
58 of 60 checks passed
@daltonbohning daltonbohning deleted the kjacque/2.6/valgrind-suppressions branch December 18, 2024 16:53
@juszhan1 juszhan1 mentioned this pull request Dec 23, 2024
Closed
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjacque @daosbuild1 @tanabarr @knard38 @daltonbohning