Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16932 dfuse: do not flush dentries at fs stop #15712

Merged
merged 1 commit into from
Jan 10, 2025
Merged

DAOS-16932 dfuse: do not flush dentries at fs stop #15712

merged 1 commit into from
Jan 10, 2025
+18 −60

Conversation

jxiong
Copy link
Contributor

@jxiong jxiong commented Jan 9, 2025 •
edited
Loading

This operation will never succeed since the file system is already unmounted. Therefore it always returns EBADF from libfuse.

Actually, it should not attempt to do that since dentries will be cleared by kernel at the time of unmounting.

Change-Id: I18eaffc0437d05e5ccc50d0a548451c4837cb1f9
Run-GHA: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jxiong
DAOS-16932 dfuse: do not flush dentries at fs stop
3f698c9 
This operation will never succeed since the file system is already
unmounted. Therefore it always returns EBADF from libfuse.

Actually, it should not attempt to do that since dentries will be
cleared by kernel at the time of unmounting.

Change-Id: I18eaffc0437d05e5ccc50d0a548451c4837cb1f9
Signed-off-by: Jinshan Xiong <jinshanx@google.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Ticket title is 'dfuse should not try to invalidate dentries at fs stop'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16932

jolivier23
jolivier23 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be upstreamed?

src/client/dfuse/dfuse_core.c
@@ -1636,10 +1601,10 @@ dfuse_cont_close_cb(d_list_t *rlink, void *handle)
static int
dfuse_pool_close_cb(d_list_t *rlink, void *handle)
{
struct dfuse_info *dfuse_info = handle;
struct dfuse_info *dfuse_info = handle;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these whitespace changes made by clang?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. I kept those because I think these are good changes.

@jxiong jxiong requested a review from a team January 10, 2025 18:04
@jolivier23 jolivier23 merged commit 3691c98 into google/2.6 Jan 10, 2025
50 of 52 checks passed
@jolivier23 jolivier23 deleted the jxiong/dfuse_not_flush branch January 10, 2025 18:28
@jxiong
Copy link
Contributor Author

jxiong commented Jan 10, 2025

master PR: #15717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiliamhuang wiliamhuang wiliamhuang approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

@wangdi1 wangdi1 Awaiting requested review from wangdi1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxiong @jolivier23 @wiliamhuang