Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16943 rebuild: check DAOS_REBUILD ENV for restart #15729

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Open

DAOS-16943 rebuild: check DAOS_REBUILD ENV for restart #15729

wants to merge 1 commit into from
+16 −3

Conversation

liuxuezhao
Copy link
Contributor

For restart, check DAOS_REBUILD ENV in ds_rebuild_regenerate_task to make it be able to disable rebuild.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners January 14, 2025 07:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Ticket title is 'DAOS_REBUILD ENV has no effect on ds_rebuild_regenerate_task when restart'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16943

@liuxuezhao liuxuezhao requested review from liw and kccain January 14, 2025 07:10
@liuxuezhao liuxuezhao changed the title DAOS-16943 rebuild: check DAOS_REBUILD ENV also for restart DAOS-16943 rebuild: check DAOS_REBUILD ENV for restart Jan 14, 2025
@liuxuezhao liuxuezhao requested review from a team as code owners January 15, 2025 02:35
DAOS-16943 rebuild: check DAOS_REBUILD ENV also for restart
5544d26 
For restart, check DAOS_REBUILD ENV in ds_rebuild_regenerate_task
to make it be able to disable rebuild.

Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
@liuxuezhao liuxuezhao removed request for a team January 15, 2025 02:54
@liuxuezhao liuxuezhao added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccain kccain kccain approved these changes

@liw liw liw approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxuezhao @liw @kccain