Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mschaara/oid assert #15732

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Mschaara/oid assert #15732

wants to merge 2 commits into from

Conversation

mchaarawi
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mchaarawi
DAOS-16931 container: fix the oid iv check for same request
f9e119b 
on retry the priv pointer is always freed/allocated, so use the sgl iov pointer instead.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Mschaara/oid

@mchaarawi mchaarawi force-pushed the mschaara/oid_assert branch from f815d50 to 7aea82e Compare January 14, 2025 19:46
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15732/5/display/redirect

@mchaarawi mchaarawi force-pushed the mschaara/oid_assert branch from 7aea82e to 8bd4ced Compare January 14, 2025 21:04
@mchaarawi
DAOS-16931 container: just for debug
50bc7b4 
Quick-Functional: true
Test-tag: test_daos_dfs_unit
Test-repeat: 10

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
@mchaarawi mchaarawi force-pushed the mschaara/oid_assert branch from 8bd4ced to 50bc7b4 Compare January 14, 2025 21:05
@mchaarawi mchaarawi mentioned this pull request Jan 14, 2025
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchaarawi @daosbuild1