Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16868 bio: Skip LED reset on absent bdev (#15718) #15733

Merged
merged 1 commit into from
Jan 15, 2025
Merged

DAOS-16868 bio: Skip LED reset on absent bdev (#15718) #15733

merged 1 commit into from
Jan 15, 2025

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jan 14, 2025 •
edited
Loading

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr
DAOS-16868 bio: Skip LED reset on absent bdev (#15718)
d38853c 
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr added the bug label Jan 14, 2025
@tanabarr tanabarr requested review from kjacque and knard38 January 14, 2025 16:57
@tanabarr tanabarr self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16868

@tanabarr tanabarr added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 14, 2025
@tanabarr tanabarr marked this pull request as ready for review January 14, 2025 16:57
@tanabarr tanabarr requested review from a team as code owners January 14, 2025 16:57
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15733/1/testReport/

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 15, 2025
@tanabarr
Copy link
Contributor Author

CI https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15733/1/pipeline/ hitting unrelated NLT memcheck failure

@tanabarr tanabarr requested a review from a team January 15, 2025 16:55
@daltonbohning daltonbohning merged commit 9a1b410 into release/2.6 Jan 15, 2025
60 of 62 checks passed
@daltonbohning daltonbohning deleted the tanabarr/bio-start-with-bad-dev-rel2_6 branch January 15, 2025 17:56
This was referenced Jan 22, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque kjacque approved these changes

Assignees

@tanabarr tanabarr

Labels
bug clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanabarr @daosbuild1 @kjacque @knard38 @daltonbohning