Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16971 utils: two patches from Jerome to fix progress hang #15766

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Jan 22, 2025

Two patches from Jerome to fix progress hang

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1 wangdi1 requested review from jolivier23 and corwin January 22, 2025 18:28
Copy link

github-actions bot commented Jan 22, 2025

Ticket title is 'bulk cancel causing libfabric progress failure.'
Status is 'Open'
Labels: 'GCP,google-cloud-daos'
https://daosio.atlassian.net/browse/DAOS-16971

@wangdi1 wangdi1 requested a review from mjmac January 22, 2025 18:29
@wangdi1 wangdi1 force-pushed the wangdi/google_26_ofi branch from e26fbad to 64ae3f6 Compare January 23, 2025 02:46
@wangdi1 wangdi1 changed the title DAOS-16971 ofi: add ofi_mrecv patch to OFI build DAOS-16971 utils: two patches from Jerome to fix progress hang Jan 23, 2025
@jolivier23 jolivier23 force-pushed the wangdi/google_26_ofi branch 4 times, most recently from e3553ab to 5dbf087 Compare January 23, 2025 03:42
Two patches from Jerome to fix progress hang

Change-Id: I22ea3364f0b5605071d39e26ac16a72645351686
Signed-off-by: Di Wang <ddiwang@google.com>
Co-authored-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the wangdi/google_26_ofi branch from 5dbf087 to fc63c2e Compare January 23, 2025 03:43
update mercury patch from Jerome

Signed-off-by: Di Wang <ddiwang@google.com>
@jolivier23 jolivier23 merged commit 9e157fc into google/2.6 Jan 23, 2025
69 of 72 checks passed
@jolivier23 jolivier23 deleted the wangdi/google_26_ofi branch January 23, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants