DAOS-7015 event: proper event handing in case of progress errors #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daosbuild1
previously requested changes
Mar 12, 2021
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4981/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
src/client/api/event.c
Outdated
| continue; | ||
| if (rc) | ||
| break; | ||
| else |
There was a problem hiding this comment.
(style) else is not generally useful after a break or return
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4981/1/execution/node/72/log |
- exit loop if event error is reported Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
mchaarawi
force-pushed
the
mschaara/event_prog_errs
branch
from
2f81eac to
6c7bc4e
Compare
daosbuild1
reviewed
Mar 12, 2021
jolivier23
approved these changes
Mar 12, 2021
gnailzenh
approved these changes
Mar 12, 2021
daosbuild1
reviewed
Mar 15, 2021
|
@daos-stack/daos-gatekeeper three test failure in: The PR to fix those tests is still inflight. |
jolivier23
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohamad Chaarawi mohamad.chaarawi@intel.com