Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-6808 misc: Fix cleanuping resources #5010

Merged
merged 3 commits into from
Mar 17, 2021
Merged

DAOS-6808 misc: Fix cleanuping resources #5010

merged 3 commits into from
Mar 17, 2021

Conversation

dmiter
Copy link
Contributor

@dmiter dmiter commented Mar 15, 2021

  • Free memory in an error path

Dmitry Eremin added 3 commits March 14, 2021 16:24
DAOS-6808 misc: Fix cleanuping resources
dfbcea2 
- Free memory in an error path

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Merge branch 'master' into deremin/DAOS-6808-3
c1d8f98
address comments
26ea4d0 
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
daosbuild1
daosbuild1 reviewed Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

mchaarawi
mchaarawi previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of this look fine to me. someone else more familiar with the code needs to look at the changes in srv_obj.c and srv_target.c

ashleypittman
ashleypittman reviewed Mar 15, 2021
View reviewed changes
src/object/srv_obj.c Outdated Show resolved Hide resolved
@dmiter dmiter force-pushed the deremin/DAOS-6808-3 branch from e763018 to 1fc48db Compare March 15, 2021 17:01
daosbuild1
daosbuild1 previously requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5010/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_internal.h Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/72/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/337/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Ubuntu 20.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/516/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/535/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/520/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/373/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 debug completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/2/execution/node/473/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Ubuntu 20.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/452/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/533/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/535/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/382/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 debug completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/514/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 release completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/515/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/471/log

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5010/3/execution/node/521/log

@dmiter dmiter force-pushed the deremin/DAOS-6808-3 branch from 1fc48db to dfbcea2 Compare March 15, 2021 18:43
@daosbuild1 daosbuild1 dismissed their stale review March 15, 2021 18:45

Updated patch

daosbuild1
daosbuild1 reviewed Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

ashleypittman
ashleypittman reviewed Mar 15, 2021
View reviewed changes
src/object/srv_obj.c Outdated Show resolved Hide resolved
jolivier23
jolivier23 requested changes Mar 15, 2021
View reviewed changes
src/object/srv_obj.c Show resolved Hide resolved
Nasf-Fan
Nasf-Fan reviewed Mar 16, 2021
View reviewed changes
src/object/srv_ec_aggregate.c Show resolved Hide resolved
src/object/srv_obj.c Show resolved Hide resolved
daosbuild1
daosbuild1 reviewed Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@johannlombardi johannlombardi merged commit 3784fcd into master Mar 17, 2021
@johannlombardi johannlombardi deleted the deremin/DAOS-6808-3 branch March 17, 2021 14:06
dmiter pushed a commit that referenced this pull request Apr 6, 2021
DAOS-6808 misc: Fix cleanuping resources (#5010)
b999d7c 
Free memory in an error path

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
jolivier23 pushed a commit that referenced this pull request May 12, 2021
DAOS-6808 misc: Fix cleaning up resources (#5010) (#5340)
e46907f 
Free memory in an error path

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
@ashleypittman ashleypittman mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

@wangdi1 wangdi1 Awaiting requested review from wangdi1

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dmiter @daosbuild1 @liuxuezhao @ashleypittman @mchaarawi @jolivier23 @Nasf-Fan @johannlombardi