Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-7446 test: Run container/filesystem copy under fault injection. #5655

Merged
merged 28 commits into from
Jun 16, 2021
Merged

DAOS-7446 test: Run container/filesystem copy under fault injection. #5655

merged 28 commits into from
Jun 16, 2021

Conversation

ashleypittman
Copy link
Contributor

Add a test to NLT to run 'daos filesystem copy' under fault
injection.

Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com

@ashleypittman
??? test: Run container/filesystem copy under fault injection.
b971e4e 
Add a test to NLT to run 'daos filesystem copy' under fault
injection.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
daosbuild1
daosbuild1 previously requested changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:2736:
(pylint-too-many-branches) Too many branches (26/25)

utils/node_local_test.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/1/execution/node/123/log

@ashleypittman
Copy link
Contributor Author

This PR looks to be hitting at least one assert() in src/utils/daos_hdlr.c that should be D_ASSERT()

@daosbuild1
Copy link
Collaborator

Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/1/execution/node/884/log

@ashleypittman
Fix three of the errors, and disable some of the checks
93bec3b 
for now, so NLT will re-run crashes under valgrind.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review May 6, 2021 10:46

Updated patch

daosbuild1
daosbuild1 previously requested changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:2741:
(pylint-too-many-branches) Too many branches (26/25)

src/client/array/dc_array.c Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/2/execution/node/104/log

@daosbuild1
Copy link
Collaborator

Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/2/execution/node/884/log

@ashleypittman ashleypittman changed the title ??? test: Run container/filesystem copy under fault injection. DAOS-7446 test: Run container/filesystem copy under fault injection. May 6, 2021
fix daos_hdlr errors
68f9ebe 
Features: fs_copy

Signed-off-by: Dalton Bohning <daltonx.bohning@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review May 6, 2021 16:33

Updated patch

daosbuild1
daosbuild1 previously requested changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:2741:
(pylint-too-many-branches) Too many branches (26/25)

src/client/array/dc_array.c Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/3/execution/node/99/log

@daosbuild1
Copy link
Collaborator

Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/3/execution/node/950/log

@ashleypittman
Update dfs logging.
f956599 
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@ashleypittman
Merge branch 'master' into fs-copy-fi
7e4ddef
@daosbuild1 daosbuild1 dismissed their stale review May 12, 2021 17:24

Updated patch

daosbuild1
daosbuild1 previously requested changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:2779:
(pylint-too-many-branches) Too many branches (26/25)

src/client/array/dc_array.c Outdated Show resolved Hide resolved
src/client/dfs/dfs.c Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/4/execution/node/96/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/4/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/4/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage NLT completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/4/execution/node/778/log

@ashleypittman
Merge branch 'master' into fs-copy-fi
468740b
@ashleypittman
Fix one more dfs warning.
778aca7 
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review May 13, 2021 09:21

Updated patch

daosbuild1
daosbuild1 previously requested changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:2775:
(pylint-too-many-branches) Too many branches (26/25)

src/client/array/dc_array.c Outdated Show resolved Hide resolved
src/client/dfs/dfs.c Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
@ashleypittman
Copy link
Contributor Author

I've disabled the test from running in CI as it's incomplete, however I'd like to land this PR as-is because it contains a number of valuable fixes. Can I ask for fresh reviews please?

daltonbohning
daltonbohning reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are just output formatting questions

src/client/array/dc_array.c Show resolved Hide resolved
src/client/dfs/dfs.c Show resolved Hide resolved
src/client/dfs/dfs.c Show resolved Hide resolved
src/client/dfs/dfs.c Show resolved Hide resolved
src/common/prop.c Show resolved Hide resolved
daltonbohning
daltonbohning previously approved these changes Jun 9, 2021
View reviewed changes
@daosbuild1 daosbuild1 dismissed their stale review June 10, 2021 01:48

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/20/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:3113:
(pylint-too-many-branches) Too many branches (26/25)

utils/node_local_test.py Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
utils/node_local_test.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/20/execution/node/87/log

@ashleypittman
Update to new API.
c449227 
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
@daosbuild1 daosbuild1 dismissed their stale review June 10, 2021 08:34

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/21/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:3108:
(pylint-too-many-branches) Too many branches (26/25)

utils/node_local_test.py Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/21/execution/node/101/log

@daosbuild1 daosbuild1 dismissed their stale review June 14, 2021 13:58

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/22/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:3112:
(pylint-too-many-branches) Too many branches (26/25)

utils/node_local_test.py Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/22/execution/node/100/log

@daosbuild1 daosbuild1 dismissed their stale review June 16, 2021 09:15

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-5655/23/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/node_local_test.py:3128:
(pylint-too-many-branches) Too many branches (26/25)

utils/node_local_test.py Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5655/23/execution/node/100/log

@github-actions

This comment has been minimized.

Sign in to view
@ashleypittman ashleypittman dismissed daosbuild1’s stale review June 16, 2021 15:51

Legitimate TODO item.

@ashleypittman ashleypittman merged commit 9e44b96 into master Jun 16, 2021
@ashleypittman ashleypittman deleted the fs-copy-fi branch June 16, 2021 18:43
@github-actions
Copy link

Unit Test Results

1 files  1 suites   47s ⏱️
7 tests 7 ✔️ 0 💤 0 ❌

Results for commit 9e44b96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@dsikich dsikich dsikich approved these changes

@daosbuild1 daosbuild1 daosbuild1 left review comments

@dmiter dmiter Awaiting requested review from dmiter

Assignees

@daltonbohning daltonbohning

@dsikich dsikich

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashleypittman @daosbuild1 @dmiter @daltonbohning @dsikich