DAOS-1386 test container snapshot info DAOS-1402 DAOS-1390 #573

dinghwah · 2019-06-04T19:17:32Z

Updated file: src/utils/py/daos_api.py
New file: src/tests/ftest/container/snapshot_info_test.py
New file: src/tests/ftest/container/snapshot_info_test.yaml

Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/tests/ftest/container/snapshot_info_test.py:97:
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:99:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:100:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:102:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:104:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:106:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:108:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:110:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:111:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:112:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:115:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:117:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:118:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:119:
(pylint-undefined-variable) Undefined variable 'step'
(pylint-unused-variable) Unused variable 'substep'

src/tests/ftest/container/snapshot_info_test.py:123:
(pylint-undefined-variable) Undefined variable 'step'

src/tests/ftest/container/snapshot_info_test.py:128:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:130:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:132:
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:134:
(pylint-invalid-name) Invalid variable name "ct"
(pylint-unused-variable) Unused variable 'ct'

src/tests/ftest/container/snapshot_info_test.py:143:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:149:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:153:
(pylint-invalid-name) Invalid method name "test_snapshot_create_negativetest"
(pylint-too-many-locals) Too many local variables (25/20)
(pylint-too-many-branches) Too many branches (14/12)
(pylint-too-many-statements) Too many statements (98/50)

src/tests/ftest/container/snapshot_info_test.py:183:
(pylint-bad-continuation) Wrong continued indentation (add 8 spaces).

src/tests/ftest/container/snapshot_info_test.py:200:
(pylint-bad-continuation) Wrong hanging indentation before block (add 4 spaces).

src/tests/ftest/container/snapshot_info_test.py:204:
(pylint-logging-format-interpolation) Use % formatting in logging functions and pass the % parameters as arguments

src/tests/ftest/container/snapshot_info_test.py:205:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:217:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:222:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:223:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:224:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:225:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:228:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:234:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:235:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:237:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:252:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:253:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:255:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:257:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:259:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:260:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:261:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:264:
(pylint-bad-continuation) Wrong continued indentation (add 12 spaces).

src/tests/ftest/container/snapshot_info_test.py:266:
(pylint-bad-continuation) Wrong continued indentation (add 6 spaces).

src/tests/ftest/container/snapshot_info_test.py:276:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:278:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:280:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:285:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:291:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:293:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:295:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:298:
(pylint-bad-continuation) Wrong continued indentation (add 6 spaces).

src/tests/ftest/container/snapshot_info_test.py:303:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:305:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:307:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:310:
(pylint-bad-continuation) Wrong continued indentation (add 7 spaces).

src/tests/ftest/container/snapshot_info_test.py:329:
(pylint-too-many-locals) Too many local variables (33/20)
(pylint-too-many-branches) Too many branches (17/12)
(pylint-too-many-statements) Too many statements (125/50)

src/tests/ftest/container/snapshot_info_test.py:55:
(pylint-invalid-name) Invalid method name "display_daosContainer"
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:354:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'coh_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:355:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'container_epoch_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:356:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'snapshot_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:357:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'test_data' defined outside init

src/tests/ftest/container/snapshot_info_test.py:396:
(pylint-logging-format-interpolation) Use % formatting in logging functions and pass the % parameters as arguments

src/tests/ftest/container/snapshot_info_test.py:397:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:411:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:419:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:425:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:426:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:428:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:433:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:446:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:448:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:472:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:473:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:475:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:477:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:479:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:480:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:481:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:484:
(pylint-bad-continuation) Wrong continued indentation (add 12 spaces).

src/tests/ftest/container/snapshot_info_test.py:486:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:496:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:498:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:506:
(pylint-bad-continuation) Wrong continued indentation (add 11 spaces).

src/tests/ftest/container/snapshot_info_test.py

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/tests/ftest/container/snapshot_info_test.py:97:
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:99:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:100:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:102:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:104:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:106:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:108:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:110:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:111:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:112:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:115:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:117:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:118:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:119:
(pylint-undefined-variable) Undefined variable 'step'
(pylint-unused-variable) Unused variable 'substep'

src/tests/ftest/container/snapshot_info_test.py:123:
(pylint-undefined-variable) Undefined variable 'step'

src/tests/ftest/container/snapshot_info_test.py:128:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:130:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:132:
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:134:
(pylint-invalid-name) Invalid variable name "ct"
(pylint-unused-variable) Unused variable 'ct'

src/tests/ftest/container/snapshot_info_test.py:143:
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:149:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:153:
(pylint-invalid-name) Invalid method name "test_snapshot_create_negativetest"
(pylint-too-many-locals) Too many local variables (25/20)
(pylint-too-many-branches) Too many branches (14/12)
(pylint-too-many-statements) Too many statements (98/50)

src/tests/ftest/container/snapshot_info_test.py:183:
(pylint-bad-continuation) Wrong continued indentation (add 8 spaces).

src/tests/ftest/container/snapshot_info_test.py:200:
(pylint-bad-continuation) Wrong hanging indentation before block (add 4 spaces).

src/tests/ftest/container/snapshot_info_test.py:204:
(pylint-logging-format-interpolation) Use % formatting in logging functions and pass the % parameters as arguments

src/tests/ftest/container/snapshot_info_test.py:205:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:217:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:222:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:223:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:224:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:225:
(pylint-bad-continuation) Wrong continued indentation (remove 5 spaces).

src/tests/ftest/container/snapshot_info_test.py:228:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:234:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:235:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:237:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:252:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:253:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:255:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:257:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:259:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:260:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:261:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:264:
(pylint-bad-continuation) Wrong continued indentation (add 12 spaces).

src/tests/ftest/container/snapshot_info_test.py:266:
(pylint-bad-continuation) Wrong continued indentation (add 6 spaces).

src/tests/ftest/container/snapshot_info_test.py:276:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:278:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:280:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:285:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:291:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:293:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:295:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:298:
(pylint-bad-continuation) Wrong continued indentation (add 6 spaces).

src/tests/ftest/container/snapshot_info_test.py:303:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:305:
(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py:307:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:310:
(pylint-bad-continuation) Wrong continued indentation (add 7 spaces).

src/tests/ftest/container/snapshot_info_test.py:329:
(pylint-too-many-locals) Too many local variables (33/20)
(pylint-too-many-branches) Too many branches (17/12)
(pylint-too-many-statements) Too many statements (125/50)

src/tests/ftest/container/snapshot_info_test.py:55:
(pylint-invalid-name) Invalid method name "display_daosContainer"
(pylint-missing-docstring) Missing method docstring

src/tests/ftest/container/snapshot_info_test.py:354:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'coh_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:355:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'container_epoch_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:356:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'snapshot_list' defined outside init

src/tests/ftest/container/snapshot_info_test.py:357:
(pylint-bad-whitespace) Exactly one space required before assignment
(pylint-attribute-defined-outside-init) Attribute 'test_data' defined outside init

src/tests/ftest/container/snapshot_info_test.py:396:
(pylint-logging-format-interpolation) Use % formatting in logging functions and pass the % parameters as arguments

src/tests/ftest/container/snapshot_info_test.py:397:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:411:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:419:
(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py:425:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:426:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:428:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:433:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:446:
(pylint-bad-continuation) Wrong continued indentation (add 26 spaces).

src/tests/ftest/container/snapshot_info_test.py:448:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:472:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:473:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:475:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:477:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:479:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:480:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:481:
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:484:
(pylint-bad-continuation) Wrong continued indentation (add 12 spaces).

src/tests/ftest/container/snapshot_info_test.py:486:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).

src/tests/ftest/container/snapshot_info_test.py:496:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:498:
(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py:506:
(pylint-bad-continuation) Wrong continued indentation (add 11 spaces).

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T19:20:42Z

src/tests/ftest/container/snapshot_info_test.py

+        try:
+            for ind in range(0, len(self.container_epoch_list)):
+                epoch = self.container_epoch_list[ind]
+                ss = self.snapshot_list[ind]


(pylint-invalid-name) Invalid variable name "ss"

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T19:20:42Z

src/tests/ftest/container/snapshot_info_test.py

+import sys
+import random
+import string
+import json


(pylint-unused-import) Unused import json

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T19:20:44Z

src/tests/ftest/container/snapshot_info_test.py

+        self.log.info("self.container.info.es_glre=       %s"
+            ,self.container.info.es_glre)
+        self.log.info("self.container.info.es_ghpce=      %s"
+            ,self.container.info.es_ghpce)


(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T19:20:44Z

src/tests/ftest/container/snapshot_info_test.py

+        self.log.info("self.container.info.ci_nsnapshots= %s"
+            ,self.container.info.ci_nsnapshots)
+        self.log.info("self.container.info.ci_snapshots=  %s"
+            ,self.container.info.ci_snapshots)


(pylint-bad-continuation) Wrong continued indentation (add 10 spaces).
(pylint-bad-whitespace) Exactly one space required after comma

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T19:20:50Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/1/execution/node/44/log

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

…AOS-1386 Conflicts: src/tests/ftest/container/snapshot_info_test.py

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T22:55:40Z

src/tests/ftest/container/snapshot_info_test.py

+            coh = container
+            self.snapshot = DaosSnapshot(self.context)
+            self.snapshot.create(coh, epoch)
+        except:


(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T22:55:40Z

src/tests/ftest/container/snapshot_info_test.py

+        self.display_snapshot(snapshot)    #display ss info after ss created
+        return snapshot
+
+    def test_snapshot_create_negtest(self):


(pylint-too-many-locals) Too many local variables (25/20)
(pylint-too-many-branches) Too many branches (14/12)
(pylint-too-many-statements) Too many statements (98/50)

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T22:55:42Z

src/tests/ftest/container/snapshot_info_test.py

+                                                obj_cls=obj_cls)
+            obj.close()
+            ##Take a snapshot of the container
+            self.snapshot = DaosSnapshot(self.context)


(pylint-attribute-defined-outside-init) Attribute 'snapshot' defined outside init

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T22:55:43Z

src/tests/ftest/container/snapshot_info_test.py

+        try:
+            for ind in range(0, len(container_epoch_list)):
+                epoch = container_epoch_list[ind]
+                ss = snapshot_list[ind]


(pylint-invalid-name) Invalid variable name "ss"

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-04T22:55:52Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/2/execution/node/44/log

…-1386

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-06T22:24:29Z

src/tests/ftest/container/snapshot_info_test.py

+            # initialize a python pool object then create the underlying
+            # daos storage
+            self.pool = DaosPool(self.context)
+            self.pool.create(createmode, createuid, creategid, createsize, createsetid, None)


(pylint-line-too-long) Line too long (93/80)

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-06T22:24:30Z

src/tests/ftest/container/snapshot_info_test.py

+        try:
+            snapshot = DaosSnapshot(self.context)
+            snapshot.create(coh, epoch)
+        except:


(pylint-bare-except) No exception type(s) specified

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-06T22:24:34Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/3/execution/node/44/log

…-1386

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/container/snapshot_info_test.py

daosbuild1 · 2019-06-07T16:15:36Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/4/execution/node/44/log

src/tests/ftest/container/snapshot_info_test.py

src/tests/ftest/container/snapshot_info_test.yaml

src/tests/ftest/container/snapshot_info_test.py

dinghwah · 2019-06-10T14:56:48Z

Saurabh,
Thanks for the review and comments, I have addressed all the comments on the updated test scripts. I also change the test script name to: snapshot_functionality_test.py and .yaml.
Please review.
Thanks, Ding.

dinghwah · 2019-06-10T14:56:55Z

Saurabh,
Thanks for the review and comments, I have addressed all the comments on the updated test scripts. I also change the test script name to: snapshot_functionality_test.py and .yaml.
Please review.
Thanks, Ding.

…-1386

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

…AOS-1386

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/9/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-06-18T17:51:22Z

src/tests/ftest/container/snapshot_functionality_test.py

+                      "taking snapshot with a NULL epoch.")
+
+
+    def test_snapshot_info(self):


(pylint-too-many-locals) Too many local variables (29/20)
(pylint-too-many-statements) Too many statements (93/50)

daosbuild1 · 2019-06-18T17:51:25Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/9/execution/node/45/log

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/10/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/container/snapshot_functionality_test.py

daosbuild1 · 2019-06-18T18:01:49Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/10/execution/node/45/log

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

saurabhtandan

LGTM

src/tests/ftest/container/snapshot_functionality_test.py

brianjmurrell

-1 just until we come to a conclusion about the tearDown().

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

src/tests/ftest/container/snapshot_functionality_test.py

… DAOS-1395) Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot.py New file: src/tests/ftest/container/snapshot.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-573/14/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/container/snapshot.py

daosbuild1 · 2019-06-21T19:52:47Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-573/14/execution/node/44/log

… DAOS-1371) Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot.py New file: src/tests/ftest/container/snapshot.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Updated patch

johannlombardi · 2019-06-24T13:09:23Z

src/utils/py/daos_api.py

@@ -1876,13 +1876,15 @@ def create(self, coh, epoch):
    #  snapshots and the epochs and names lists. See description of
    #  daos_cont_list_snap in src/include/daos_api.h. This must be done for
    #  DAOS-1336 Verify container snapshot info.
-    def list(self, coh):
+    def list(self, coh, epoch=None):


From the C API:

\param[out] epochs preallocated array of epochs to store snapshots.

So this is actually where we return the snapshot list.

johannlombardi · 2019-06-24T13:12:25Z

src/utils/py/daos_api.py

        """ Call daos_cont_snap_list and make sure there is a snapshot in the
        list.
        coh --ctype.u_long handle on an open container
        Returns the value of the epoch for this DaosSnapshot object.
        """
        func = self.context.get_function('list-snap')
+        if epoch is None:
+            epoch = self.epoch
        num = ctypes.c_uint64(1)
        epoch = ctypes.c_uint64(self.epoch)
        anchor = Anchor()


I think we should just report back a dictionary with the list of epochs that have been snapshotted.

johannlombardi · 2019-06-24T13:13:18Z

src/utils/py/daos_api.py

@@ -1893,13 +1895,15 @@ def list(self, coh):
                               .format(retcode))
        return epoch.value

-    def open(self, coh):
+    def open(self, coh, epoch=None):


If the intent is really to open a snapshot, then the epoch should be mandatory there.

johannlombardi · 2019-06-24T13:13:29Z

src/utils/py/daos_api.py

@@ -1908,7 +1912,7 @@ def open(self, coh):
                               .format(retcode))
        return txhndl

-    def destroy(self, coh, evnt=None):
+    def destroy(self, coh, epoch=None, evnt=None):


Same comment here.

johannlombardi · 2019-06-24T13:13:42Z

src/utils/py/daos_api.py

@@ -1917,6 +1921,8 @@ def destroy(self, coh, evnt=None):
        # need container handle coh, and the epoch range
        """
        func = self.context.get_function('destroy-snap')
+        if epoch is None:
+            epoch = self.epoch


We should remove the notion of self.epoch totally IMO.

DAOS-1386 test container snapshot info DAOS-1402 DAOS-1390

15885b7

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 4, 2019

View reviewed changes

dinghwah added 3 commits June 4, 2019 22:38

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

b391ea9

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Merge branch 'DAOS-1386' of https://github.com/daos-stack/daos into D…

881d739

…AOS-1386 Conflicts: src/tests/ftest/container/snapshot_info_test.py

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

bb32091

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 4, 2019

View reviewed changes

dinghwah added 2 commits June 6, 2019 22:14

Merge branch 'master' of https://github.com/daos-stack/daos into DAOS…

04c7242

…-1386

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

7971378

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 6, 2019

View reviewed changes

dinghwah requested a review from daosbuild1 June 7, 2019 15:57

dinghwah self-assigned this Jun 7, 2019

dinghwah requested review from NiuYawei and saurabhtandan June 7, 2019 16:08

dinghwah added 2 commits June 7, 2019 16:11

Merge branch 'master' of https://github.com/daos-stack/daos into DAOS…

cae9c7e

…-1386

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

18c9438

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 7, 2019

View reviewed changes

src/tests/ftest/container/snapshot_info_test.py Outdated Show resolved Hide resolved

saurabhtandan requested changes Jun 7, 2019

View reviewed changes

dinghwah added 2 commits June 10, 2019 15:01

Merge branch 'master' of https://github.com/daos-stack/daos into DAOS…

b8c0f55

…-1386

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

ad52bf8

New file: src/tests/ftest/container/snapshot_info_test.py New file: src/tests/ftest/container/snapshot_info_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

dinghwah added 3 commits June 18, 2019 17:43

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

7ebffa3

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

Merge branch 'master' into DAOS-1386

256888e

Merge branch 'DAOS-1386' of https://github.com/daos-stack/daos into D…

61b5854

…AOS-1386

daosbuild1 previously requested changes Jun 18, 2019

View reviewed changes

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

0e87153

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 18, 2019

View reviewed changes

src/tests/ftest/container/snapshot_functionality_test.py Outdated Show resolved Hide resolved

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

40ec509

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

636d1f6

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

dinghwah requested a review from saurabhtandan June 18, 2019 19:36

saurabhtandan previously approved these changes Jun 19, 2019

View reviewed changes

okulkarni previously approved these changes Jun 19, 2019

View reviewed changes

brianjmurrell reviewed Jun 19, 2019

View reviewed changes

src/tests/ftest/container/snapshot_functionality_test.py Outdated Show resolved Hide resolved

brianjmurrell suggested changes Jun 19, 2019

View reviewed changes

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390)

f775cdf

Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot_functionality_test.py New file: src/tests/ftest/container/snapshot_functionality_test.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

dinghwah dismissed stale reviews from okulkarni and saurabhtandan via f775cdf June 19, 2019 19:32

johannlombardi requested changes Jun 20, 2019

View reviewed changes

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390 DAOS-1371…

9303047

… DAOS-1395) Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot.py New file: src/tests/ftest/container/snapshot.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

daosbuild1 previously requested changes Jun 21, 2019

View reviewed changes

src/tests/ftest/container/snapshot.py Outdated Show resolved Hide resolved

src/tests/ftest/container/snapshot.py Outdated Show resolved Hide resolved

DAOS-1386 test container snapshot info (DAOS-1402 DAOS-1390 DAOS-1370…

edcbc75

… DAOS-1371) Updated file: src/utils/py/daos_api.py New file: src/tests/ftest/container/snapshot.py New file: src/tests/ftest/container/snapshot.yaml Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>

johannlombardi reviewed Jun 24, 2019

View reviewed changes

johannlombardi merged commit 1fc8264 into master Jun 25, 2019

johannlombardi deleted the DAOS-1386 branch June 25, 2019 17:10

		"taking snapshot with a NULL epoch.")


		def test_snapshot_info(self):

DAOS-1386 test container snapshot info DAOS-1402 DAOS-1390 #573

DAOS-1386 test container snapshot info DAOS-1402 DAOS-1390 #573

Conversation

dinghwah commented Jun 4, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 4, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 4, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 6, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 7, 2019

dinghwah commented Jun 10, 2019

dinghwah commented Jun 10, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 18, 2019

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 18, 2019

saurabhtandan left a comment

Choose a reason for hiding this comment

brianjmurrell left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jun 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment