Skip to content

return evm errors when trying to execute failign transactions #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 17, 2020
Merged

return evm errors when trying to execute failign transactions #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02660a7
add more meaningful default error handler to sendTransaction
jellegerbrandy Jan 16, 2020
dd2d28c
return soldiity error messages where we can
jellegerbrandy Jan 16, 2020
1bc237e
improve error handling
jellegerbrandy Jan 17, 2020
fe64700
documentation
jellegerbrandy Jan 17, 2020
3582784
new doc files
jellegerbrandy Jan 17, 2020
26d7d4f
set package version to 0.2.45
jellegerbrandy Jan 17, 2020
a594802
improve vote/stake error handlers
jellegerbrandy Jan 17, 2020
e5f44c1
fix bug in sendTransaction when no error handler is provided
jellegerbrandy Jan 17, 2020
1d60fb8
set package version to 0.2.46
jellegerbrandy Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 47 additions & 55 deletions docs/classes/arc.md
View file
Open in desktop

Large diffs are not rendered by default.

19 changes: 10 additions & 9 deletions docs/classes/competition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

\+ **new Competition**(`id`: string, `context`: [Arc](arc.md)): *[Competition](competition.md)*

*Defined in [schemes/competition.ts:396](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L396)*
*Defined in [schemes/competition.ts:419](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L419)*

**Parameters:**

Expand All @@ -48,23 +48,23 @@ Name | Type |

• **context**: *[Arc](arc.md)*

*Defined in [schemes/competition.ts:396](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L396)*
*Defined in [schemes/competition.ts:419](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L419)*

___

### id

• **id**: *string*

*Defined in [schemes/competition.ts:395](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L395)*
*Defined in [schemes/competition.ts:418](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L418)*

## Methods

### createSuggestion

▸ **createSuggestion**(`options`: object): *[Operation](../globals.md#operation)‹any›*

*Defined in [schemes/competition.ts:404](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L404)*
*Defined in [schemes/competition.ts:427](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L427)*

**Parameters:**

Expand All @@ -73,8 +73,9 @@ ___
Name | Type |
------ | ------ |
`description` | string |
`tags?` | string[] |
`title` | string |
`url` | string |
`url?` | undefined | string |

**Returns:** *[Operation](../globals.md#operation)‹any›*

Expand All @@ -84,7 +85,7 @@ ___

▸ **redeemSuggestion**(`suggestionId`: number, `beneficiary`: [Address](../globals.md#address)): *[Operation](../globals.md#operation)‹boolean›*

*Defined in [schemes/competition.ts:463](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L463)*
*Defined in [schemes/competition.ts:488](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L488)*

**Parameters:**

Expand All @@ -101,7 +102,7 @@ ___

▸ **suggestions**(`options`: [ICompetitionSuggestionQueryOptions](../interfaces/icompetitionsuggestionqueryoptions.md), `apolloQueryOptions`: [IApolloQueryOptions](../interfaces/iapolloqueryoptions.md)): *Observable‹[CompetitionSuggestion](competitionsuggestion.md)[]›*

*Defined in [schemes/competition.ts:475](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L475)*
*Defined in [schemes/competition.ts:500](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L500)*

**Parameters:**

Expand All @@ -118,7 +119,7 @@ ___

▸ **voteSuggestion**(`suggestionId`: number): *[Operation](../globals.md#operation)‹[CompetitionVote](competitionvote.md)›*

*Defined in [schemes/competition.ts:452](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L452)*
*Defined in [schemes/competition.ts:477](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L477)*

**Parameters:**

Expand All @@ -134,7 +135,7 @@ ___

▸ **search**(`context`: [Arc](arc.md), `options`: [IProposalQueryOptions](../interfaces/iproposalqueryoptions.md), `apolloQueryOptions`: [IApolloQueryOptions](../interfaces/iapolloqueryoptions.md)): *Observable‹[Competition](competition.md)[]›*

*Defined in [schemes/competition.ts:385](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L385)*
*Defined in [schemes/competition.ts:408](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L408)*

**Parameters:**

Expand Down
57 changes: 38 additions & 19 deletions docs/classes/competitionscheme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
* [createProposalTransaction](competitionscheme.md#createproposaltransaction)
* [createProposalTransactionMap](competitionscheme.md#createproposaltransactionmap)
* [fetchStaticState](competitionscheme.md#fetchstaticstate)
* [getCompetitionContract](competitionscheme.md#getcompetitioncontract)
* [proposals](competitionscheme.md#proposals)
* [redeemSuggestion](competitionscheme.md#redeemsuggestion)
* [setStaticState](competitionscheme.md#setstaticstate)
Expand All @@ -52,7 +53,7 @@

*Inherited from [SchemeBase](schemebase.md).[constructor](schemebase.md#constructor)*

*Defined in [schemes/base.ts:239](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L239)*
*Defined in [schemes/base.ts:239](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L239)*

**Parameters:**

Expand All @@ -71,7 +72,7 @@ Name | Type |

*Inherited from [SchemeBase](schemebase.md).[ReputationFromToken](schemebase.md#reputationfromtoken)*

*Defined in [schemes/base.ts:239](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L239)*
*Defined in [schemes/base.ts:239](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L239)*

___

Expand All @@ -81,7 +82,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[context](schemebase.md#context)*

*Defined in [schemes/base.ts:241](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L241)*
*Defined in [schemes/base.ts:241](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L241)*

___

Expand All @@ -91,7 +92,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[id](schemebase.md#id)*

*Defined in [schemes/base.ts:237](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L237)*
*Defined in [schemes/base.ts:237](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L237)*

___

Expand All @@ -101,15 +102,15 @@ ___

*Inherited from [SchemeBase](schemebase.md).[staticState](schemebase.md#staticstate)*

*Defined in [schemes/base.ts:238](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L238)*
*Defined in [schemes/base.ts:238](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L238)*

## Methods

### competitions

▸ **competitions**(`options`: [IProposalQueryOptions](../interfaces/iproposalqueryoptions.md), `apolloQueryOptions`: [IApolloQueryOptions](../interfaces/iapolloqueryoptions.md)): *Observable‹[Competition](competition.md)[]›*

*Defined in [schemes/competition.ts:168](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L168)*
*Defined in [schemes/competition.ts:167](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L167)*

Return a list of competitions in this scheme.

Expand All @@ -130,7 +131,11 @@ ___

*Overrides [SchemeBase](schemebase.md).[createProposal](schemebase.md#createproposal)*

*Defined in [schemes/competition.ts:271](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L271)*
*Defined in [schemes/competition.ts:277](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L277)*

create a proposal for starting a Competition

**`memberof`** CompetitionScheme

**Parameters:**

Expand All @@ -148,7 +153,7 @@ ___

*Overrides [SchemeBase](schemebase.md).[createProposalErrorHandler](schemebase.md#createproposalerrorhandler)*

*Defined in [schemes/competition.ts:254](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L254)*
*Defined in [schemes/competition.ts:253](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L253)*

**Parameters:**

Expand All @@ -174,7 +179,7 @@ ___

*Overrides [SchemeBase](schemebase.md).[createProposalTransaction](schemebase.md#createproposaltransaction)*

*Defined in [schemes/competition.ts:188](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L188)*
*Defined in [schemes/competition.ts:187](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L187)*

**Parameters:**

Expand All @@ -192,7 +197,7 @@ ___

*Overrides [SchemeBase](schemebase.md).[createProposalTransactionMap](schemebase.md#createproposaltransactionmap)*

*Defined in [schemes/competition.ts:245](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L245)*
*Defined in [schemes/competition.ts:244](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L244)*

**Returns:** *txMap*

Expand All @@ -204,7 +209,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[fetchStaticState](schemebase.md#fetchstaticstate)*

*Defined in [schemes/base.ts:256](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L256)*
*Defined in [schemes/base.ts:256](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L256)*

fetch the static state from the subgraph

Expand All @@ -214,13 +219,23 @@ the statatic state

___

### getCompetitionContract

▸ **getCompetitionContract**(): *Promise‹any›*

*Defined in [schemes/competition.ts:281](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L281)*

**Returns:** *Promise‹any›*

___

### proposals

▸ **proposals**(`options`: [IProposalQueryOptions](../interfaces/iproposalqueryoptions.md), `apolloQueryOptions`: [IApolloQueryOptions](../interfaces/iapolloqueryoptions.md)): *Observable‹[Proposal](proposal.md)[]›*

*Inherited from [SchemeBase](schemebase.md).[proposals](schemebase.md#proposals)*

*Defined in [schemes/base.ts:467](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L467)*
*Defined in [schemes/base.ts:467](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L467)*

**Parameters:**

Expand All @@ -237,7 +252,7 @@ ___

▸ **redeemSuggestion**(`options`: object): *[Operation](../globals.md#operation)‹boolean›*

*Defined in [schemes/competition.ts:324](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L324)*
*Defined in [schemes/competition.ts:347](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L347)*

**Parameters:**

Expand All @@ -258,7 +273,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[setStaticState](schemebase.md#setstaticstate)*

*Defined in [schemes/base.ts:279](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L279)*
*Defined in [schemes/base.ts:279](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L279)*

**Parameters:**

Expand All @@ -276,7 +291,7 @@ ___

*Overrides [SchemeBase](schemebase.md).[state](schemebase.md#abstract-state)*

*Defined in [schemes/competition.ts:83](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L83)*
*Defined in [schemes/competition.ts:82](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L82)*

**Parameters:**

Expand All @@ -292,7 +307,11 @@ ___

▸ **voteSuggestion**(`options`: object): *[Operation](../globals.md#operation)‹[CompetitionVote](competitionvote.md)›*

*Defined in [schemes/competition.ts:275](https://github.com/daostack/client/blob/7361fcc/src/schemes/competition.ts#L275)*
*Defined in [schemes/competition.ts:296](https://github.com/daostack/client/blob/1bc237e/src/schemes/competition.ts#L296)*

Vote for the suggestion that is, in the current scheme, identified by suggestionId

**`memberof`** CompetitionScheme

**Parameters:**

Expand All @@ -312,7 +331,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[x](schemebase.md#x)*

*Defined in [schemes/base.ts:319](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L319)*
*Defined in [schemes/base.ts:319](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L319)*

**Returns:** *void*

Expand All @@ -324,7 +343,7 @@ ___

*Inherited from [SchemeBase](schemebase.md).[fragments](schemebase.md#static-fragments)*

*Defined in [schemes/base.ts:106](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L106)*
*Defined in [schemes/base.ts:106](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L106)*

### SchemeFields

Expand Down Expand Up @@ -457,4 +476,4 @@ ___
version
}`

*Defined in [schemes/base.ts:107](https://github.com/daostack/client/blob/7361fcc/src/schemes/base.ts#L107)*
*Defined in [schemes/base.ts:107](https://github.com/daostack/client/blob/1bc237e/src/schemes/base.ts#L107)*
Loading