Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long breadcrumb goes on top of "My spaces" #2718

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

pvm-code
Copy link
Collaborator

What was changed?

  • Added tooltip logic
  • Updated tooltip component
  • Optimized Breadcrumbs

Added tooltip logic
Updated tooltip component
Optimized Breadcrumbs
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 09e5723
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/66afa0ab99d70c0008fa86eb
😎 Deploy Preview https://deploy-preview-2718--preview-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pvm-code pvm-code requested a review from elatif2020 July 30, 2024 11:48
@elatif2020
Copy link
Collaborator

@MeyerPV
The tooltip is looking good but now I'm unable to click the spaces\common in the breadcrumb to open the dropdown menu (with the list of other spaces\commons)

Additionally we should add padding between the arrow down icon to the "Spaces" button, 0.75 rem

@elatif2020
Copy link
Collaborator

@MeyerPV
It's good now

@pvm-code pvm-code merged commit 84cf027 into dev Aug 5, 2024
5 checks passed
@pvm-code pvm-code deleted the CW-long-breadcrumbs branch August 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants