GP doesn't fire StateChange event when proposal moves to QuietEndingPeriod

[ben-kaufman]

When changing the state of a proposal to QuietEndingPeriod Genesis protocol currently doesn't emit a StateChange event as it would be expected to do and currently does for all other state changes.

Genesis protocol should emit a StateChange event here:
https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L706

[orenyodfat]

This is nice to have though it is not a must . Subgraph already read the proposal upon voting event and should also update its state

…

On Sun, 21 Apr 2019 at 17:34 benk10 ***@***.***> wrote: When changing the state of a proposal to QuietEndingPeriod Genesis protocol currently doesn't emit a StateChange event as it would be expected to do and currently does for all other state changes. Genesis protocol should emit a StateChange event here: https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L706 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNXPHUOKTD23ESCIRB2Y2LPRSCQDANCNFSM4HHL33LA> .