none uni voting machines #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solc 0.5.17
ben-kaufman
reviewed
May 12, 2020
| external | ||
| initializer { | ||
| require(_precReq <= 100 && _precReq > 0, "wrong precReq"); | ||
| parameters = Parameters({ |
There was a problem hiding this comment.
Why not save them directly as variables of the contract instead of keeping the struct? (In all the contracts)
There was a problem hiding this comment.
it looks better in struct . though need to check the gas diff for this 2 options.
ben-kaufman
reviewed
May 13, 2020
| @@ -1,59 +0,0 @@ | |||
| require("babel-polyfill"); | |||
There was a problem hiding this comment.
Maybe leave this like in Arc?
ben-kaufman
approved these changes
May 13, 2020
added 2 commits
May 14, 2020 01:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solc 0.5.17