-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registrar fixes #3
Commits on Feb 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8b2067b - Browse repository at this point
Copy the full SHA 8b2067bView commit details -
registrar: make immutable variables constant
These values will never change, so setting them as constants makes auditing the contract a little easier.
Configuration menu - View commit details
-
Copy full SHA for 9355838 - Browse repository at this point
Copy the full SHA 9355838View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f90793 - Browse repository at this point
Copy the full SHA 3f90793View commit details -
registrar: account for ens fallback mechanism
The new ens registry has a fallback mechanism where the old registry will be queried if an owner for a record cannot be found in the new registry. The logic for this mechanism makes use to two sentinel values for the `owner` field in a record: - `address(0)`: no owner found in the new registry, try the old one - `address(this)`: record is unowned, do not fallback to the old registrar Calling `setOwner(record, address(0))` on the new registrar will in fact set a value of `address(this)` for the owner field on that record. the `recordExists` method only checks if the owner of a domain is `address(0)` and returns `true` otherwise. The combination of the above two points meant that revoked names (where the owner had been set to `address(0)`) could not be reregistered. This commit replaces the call to `recordExists` with a check based on `ens.owner(node)` (which returns `address(0)` when the owner of a record is `address(this)`), thus allowing reregistration of intentionally revoked names.
Configuration menu - View commit details
-
Copy full SHA for 08f7218 - Browse repository at this point
Copy the full SHA 08f7218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6090129 - Browse repository at this point
Copy the full SHA 6090129View commit details -
registrar: remove redundant require
This check ensures that the owner of the "eth" tld in the ens registry has been set. However the call to `setDomainOwner` will always fail if this is not the case (due to the call to `transferFrom` later in the method). Removing as this is not a user facing method, and clarity of implementation trumps clarity of error messages in this case.
Configuration menu - View commit details
-
Copy full SHA for c39b01e - Browse repository at this point
Copy the full SHA c39b01eView commit details -
registrar: setDomainOwner does not update resolver and ttl
The `setDomainOwner` method should not set the resolver and ttl values. In particular the previous behaviour (setting the resolver to the address of the new domain owner) seems almost certain to be wrong (and cause disruption for downstream clients who may rely on the resolver for the `radicle.eth` domain).
Configuration menu - View commit details
-
Copy full SHA for e1c21ea - Browse repository at this point
Copy the full SHA e1c21eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcac3df - Browse repository at this point
Copy the full SHA fcac3dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f40518 - Browse repository at this point
Copy the full SHA 1f40518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0536426 - Browse repository at this point
Copy the full SHA 0536426View commit details -
registrar: set resolver and ttl for subdomains
Either sets a default value for the resolver and ttl, or allows the caller to specify a custom one when registering a new name.
Configuration menu - View commit details
-
Copy full SHA for c63d86c - Browse repository at this point
Copy the full SHA c63d86cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39255a4 - Browse repository at this point
Copy the full SHA 39255a4View commit details -
registrar: introduce commit / reveal scheme
This prevents an attack where a malicious actor could scan the mempool and front run name registration before charging the original registrant an extra fee.
Configuration menu - View commit details
-
Copy full SHA for 8cf11c7 - Browse repository at this point
Copy the full SHA 8cf11c7View commit details -
registrar: give admin control over ens address
The ENS registry has migrated before, and may do so again in the future, this change gives admin a little more flexibility in case such a situation arises again in the future.
Configuration menu - View commit details
-
Copy full SHA for fa1cd8f - Browse repository at this point
Copy the full SHA fa1cd8fView commit details -
registrar: enforce min time between commit and reveal
This prevents an attack where a malicious actor could frontrun a call to `register` with an atomic call to `commit` followed by `register` for the same name. 50 blocks has been (somewhat arbitrarily) chosen as a default for now, some more work is required to justify the safety of this value in the face of e.g. heavy network congestion.
Configuration menu - View commit details
-
Copy full SHA for 163f1ab - Browse repository at this point
Copy the full SHA 163f1abView commit details -
Configuration menu - View commit details
-
Copy full SHA for c14a88a - Browse repository at this point
Copy the full SHA c14a88aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 622cab2 - Browse repository at this point
Copy the full SHA 622cab2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ececfe0 - Browse repository at this point
Copy the full SHA ececfe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a127bef - Browse repository at this point
Copy the full SHA a127befView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8516530 - Browse repository at this point
Copy the full SHA 8516530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce8d22 - Browse repository at this point
Copy the full SHA 9ce8d22View commit details
Commits on Feb 6, 2021
-
- add commitWithPermit - fover RadicleToken over ERC20Burnable interface
Configuration menu - View commit details
-
Copy full SHA for 8198113 - Browse repository at this point
Copy the full SHA 8198113View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ee950 - Browse repository at this point
Copy the full SHA 31ee950View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6da8bae - Browse repository at this point
Copy the full SHA 6da8baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1abd66e - Browse repository at this point
Copy the full SHA 1abd66eView commit details