Allow minting multiple editions with the same set/play but different tiers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLin-wk
commented
Apr 13, 2023
joshuahannan
approved these changes
Apr 13, 2023
EricLin-wk
force-pushed
the
ewlin/allow-set-play-tier
branch
from
1cc01d3
to
bb9437f
Compare
EricLin-wk
commented
Apr 14, 2023
| @@ -483,7 +482,7 @@ pub contract AllDay: NonFungibleToken { | |||
| AllDay.setByID.containsKey(setID): "setID does not exist" | |||
| AllDay.playByID.containsKey(playID): "playID does not exist" | |||
| SeriesData(id: seriesID).active == true: "cannot create an Edition with a closed Series" | |||
| SetData(id: setID).setPlayExistsInEdition(playID: playID) != true: "set play combination already exists in an edition" | |||
| AllDay.getPlayTierExistsInEdition(setID, playID, tier) == false: "set play tier combination already exists in an edition" | |||
There was a problem hiding this comment.
The set + play + tier duplicate check is now done directly within the smart contract.
judezhu
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow minting multiple editions with the same set/play but different tiers. This would eliminate the need to create redundant play data for cases when we create dynamic moments/editions for multiple tiers.