Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hevm: RLP decoding #278

Closed
wants to merge 5 commits into from
Closed

hevm: RLP decoding #278

wants to merge 5 commits into from

Conversation

MrChico
Copy link
Member

@MrChico MrChico commented Sep 19, 2019

Try out with:

hevm rlpdecode --rlphexstring 0xf8cc830104c8843b9aca008303d090947ef66b77759e12caf3ddb3e4aff524e577c59d8d80b864e9c6c176000000000000000000000000000000000000000000000000000000000000002a0000000000000000000000000000000000000000000000000000000000ae2ec63ac35c0361930ebfe79f003d5126ffae73455ee598f0c0650992ffeb0e55d48f1ba0724cf21e40eacc69950b27fdc3fcbf85c90f0be7c3605f49f244c7a09090bc22a077cb625ea2ce71503fef43288b7ad5702d4eb6469cdf17b117940b91d5aa430a

@livnev
Copy link
Member

livnev commented Sep 21, 2019

@MrChico The ergonomics could use some improvements, e.g. I liked your proposal of hevm rlp --decode. Is --rlphexstring really needed? What other form of RLP-encoded input could it possibly accept?

@MrChico
Copy link
Member Author

MrChico commented Sep 21, 2019

Yeah, no the hexstring stuff is Def not needed I just didn't know how to make it without a flag because all of other commands were using flags lol

@MrChico
Copy link
Member Author

MrChico commented Sep 25, 2019

@livnev I haven't implemented --encode right now because I'm not quite sure how to write the Read instance for the RLP type that would make that not horrible to use. If you know how to do this we can get both flags.

@MrChico MrChico mentioned this pull request Sep 25, 2019
@MrChico MrChico closed this Sep 25, 2019
@MrChico MrChico deleted the rlp branch July 28, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants