Migrate from docker-compose to docker compose #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3alpha
changed the title
dappnodedev
previously approved these changes
Dec 11, 2023
|
I have tested fresh install on a NUC 13 and docker installation has been successful. However, we need to fix bind compose, as |
dappnodedev
force-pushed
the
3alpha/migrate-compose
branch
from
afc146f
to
260fb33
Compare
|
The issue with bind has been fixed after Bind |
dappnodedev
previously approved these changes
Dec 14, 2023
pablomendezroyo
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
docker-composeis deprecated, we must migrate todocker compoecommand eventually.This shouldn't have too much impact on overall system as majority of complexity of compose handling is done inside DAppManager which as its own binary, we still must be very careful about making this change.
That is the reason I added script which would make "alias" to
docker-composeso we don't inadvertanly break any functionality.I have tested this but thorough testing of this should be done as it is critical to the functionality of whole system.