-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple IP range migration #246
Conversation
DAppNode bot has built and pinned the release to an IPFS node, for commit: 778a9a9 This is a development version and should only be installed for testing purposes, install link
(by dappnodebot/build-action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG!
We need to handle this before merging: The best approach would be to detect the current IP range and set the flags accordingly before calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenVPN supports pushing multiple routes to client config. I think it we should just push both routes and both dhcp servers, similar as we have in Wireguard. That will reduce complexity and failure points. It may require bit lager changes of script generating config, but I would say it is worth it.
This PR also removes isAdmin middleware! |
Also added |
The changes should be done to reflect in the config file ### Push Configurations Below
push "dhcp-option DNS 172.33.1.2"
push "comp-lzo no"
push "route 172.33.0.0 255.255.0.0" to ### Push Configurations Below
push "dhcp-option DNS 172.33.1.2"
push "dhcp-option DNS 10.20.0.2"
push "comp-lzo no"
push "route 172.33.0.0 255.255.0.0"
push "route 10.20.0.0 255.255.255.0" |
LFG! |
Due to the code complexity, the changes made to adapt the VPN package to the new private IP range are minimum.
The new private IP range will be
10.20.0.0/24
Note that this changes will make the package stop working in the previous public IP range