v0.1.19 changes #94
Merged
v0.1.19 changes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the dyndnsClient.generateKeys() function to check if the privateKey is valid calling `EthCrypto.publicKeyByPrivateKey(privateKey)` inside a try/catch block. If the privateKey is not valid, a new one is generate, along the publicKey and domain. dyndnsClient.generateKeys() is called at every VPN startup in client.js line 72 If the privateKey is corrupted a new one will be generated in that line. On client.js line 83 `await dyndnsClient.updateIp();` is called on every VPN startup if the static IP is not set. In that case it will register the new dyndns domain.
… hotfix_privateKey_mutation
hotfix don't mutate privateKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.