Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flomesh + Dapr blog duplicate #100

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Flomesh + Dapr blog duplicate #100

wants to merge 7 commits into from
+573 −0

Conversation

hhunter-ms
Copy link
Collaborator

No description provided.

hhunter-ms and others added 3 commits March 14, 2023 19:13
@hhunter-ms
flomesh blog dupe
d8f10aa 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
remove underscore
27d88bc 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@greenie-msft
Remove unused file1
b9fbd7b 
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-ocean-0d6f6e61e-100.westus2.azurestaticapps.net

@hhunter-ms hhunter-ms mentioned this pull request Mar 15, 2023
Closed
@hhunter-ms hhunter-ms assigned hhunter-ms and unassigned hhunter-ms Mar 15, 2023
@hhunter-ms
Copy link
Collaborator Author

@naqvis - please review

naqvis
naqvis approved these changes Mar 15, 2023
View reviewed changes
Copy link

@naqvis naqvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hhunter-ms

msfussell
msfussell reviewed Mar 15, 2023
View reviewed changes
daprblog/content/posts/2023/dapr_flomesh/index.md Outdated

The diagram below demonstrates how Dapr and Flomesh service mesh can be integrated to enable cross-cluster service communication. The example consists of two components: a server-side NodeApp and a client-side curl.

The server-side NodeApp is a Dapr application, modified from the NodeApp in the [Dapr hello-kubernetes](https://github.com/dapr/quickstarts/tree/master/tutorials/hello-kubernetes) tutorial example. When it returns a response, it displays the name of the current cluster.
Copy link
Member

@msfussell msfussell Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide a link to the modified code repo also, so that people can then see/try out the modified code example?
Actually, now I see it is here https://github.com/addozhang/flomesh-dapr-demo/tree/main/nodeapp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naqvis ^^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I still need to update the doc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like it! I'll add the link Mark found

@hhunter-ms
update link
4900a09 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'flomesh_dupe' of https://github.com/dapr/blog into flom…
15d2506 
…esh_dupe
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-ocean-0d6f6e61e-100.westus2.azurestaticapps.net

@naqvis
Copy link

naqvis commented Mar 16, 2023

Thank you @hhunter-ms for all of the support and help. I have reviewed the blog post at stage site https://thankful-ocean-0d6f6e61e-100.westus2.azurestaticapps.net/

Please advise If any further action from my side is required to get it published to Dapr blog?

@hhunter-ms
Copy link
Collaborator Author

Please advise If any further action from my side is required to get it published to Dapr blog?

@naqvis the other maintainers are reviewing, but so far the feedback is confusion around the diagram showing Redis(flomesh_dapr_blog_demo_arch.png), specifically where Redis is deployed and how it relates to the cross cluster calls. Would you be able to update that to make it more clear?

@naqvis
Copy link

naqvis commented Mar 17, 2023

specifically where Redis is deployed and how it relates to the cross cluster calls. Would you be able to update that to make it more clear?

Redis in that diagram (external to clusters) is the component which shows how to do cross cluster Dapr state management and is not required or mandatory for cross cluster service calls. We can have this component removed from the diagram if its causing confusion.

So technically speaking, all cross cluster calls are done without any need of state management, and we can have Redis safely removed from diagram.

image

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-ocean-0d6f6e61e-100.westus2.azurestaticapps.net

@nyemade-uversky
Copy link

@msfussell it sounds like we're waiting on an additional reviewer from a maintainer on this - is that right?

@artursouza, @berndverst, @yaron2 could one of be a second pair of maintainer eyes to get this reviewed?

@naqvis
Copy link

naqvis commented Mar 30, 2023

Any update please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell left review comments

@naqvis naqvis naqvis approved these changes

@greenie-msft greenie-msft greenie-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hhunter-ms @naqvis @nyemade-uversky @msfussell @greenie-msft