Skip to content

Commit 28d8a84

Browse files
authored
Merge pull request #1213 from CodeMonkeyLeet/update_setup
Update setup-azure-conf-test.sh
2 parents f96a71e + 3e504f9 commit 28d8a84

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/infrastructure/conformance/azure/setup-azure-conf-test.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ echo "Created Service Principal for cert auth: ${CERT_AUTH_SP_NAME}"
218218

219219
if [[ -n ${CREDENTIALS_PATH} ]]; then
220220
SDK_AUTH_SP_INFO="$(cat ${CREDENTIALS_PATH})"
221-
SDK_AUTH_SP_APPID="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientId' | sed -E 's/(.*clientId\"\: \")|\",//g')"
222-
SDK_AUTH_SP_CLIENT_SECRET="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientSecret' | sed -E 's/(.*clientSecret\"\: \")|\",//g')"
221+
SDK_AUTH_SP_APPID="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientId' | sed -E 's/(.*clientId\"\: \")|\".*//g')"
222+
SDK_AUTH_SP_CLIENT_SECRET="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientSecret' | sed -E 's/(.*clientSecret\"\: \")|\".*//g')"
223223
if [[ -z ${SDK_AUTH_SP_APPID} || -z ${SDK_AUTH_SP_CLIENT_SECRET} ]]; then
224224
echo "Invalid credentials JSON file. Contents should match output of 'az ad sp create-for-rbac' command."
225225
exit 1
@@ -230,7 +230,7 @@ if [[ -n ${CREDENTIALS_PATH} ]]; then
230230
else
231231
SDK_AUTH_SP_NAME="${PREFIX}-conf-test-runner-sp"
232232
SDK_AUTH_SP_INFO="$(az ad sp create-for-rbac --name "${SDK_AUTH_SP_NAME}" --sdk-auth --skip-assignment --years 1)"
233-
SDK_AUTH_SP_CLIENT_SECRET="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientSecret' | sed -E 's/(.*clientSecret\"\: \")|\",//g')"
233+
SDK_AUTH_SP_CLIENT_SECRET="$(echo "${SDK_AUTH_SP_INFO}" | grep 'clientSecret' | sed -E 's/(.*clientSecret\"\: \")|\".*//g')"
234234
SDK_AUTH_SP_ID="$(az ad sp list --display-name "${SDK_AUTH_SP_NAME}" --query "[].objectId" --output tsv)"
235235
echo "${SDK_AUTH_SP_INFO}"
236236
echo "Created Service Principal for SDK Auth: ${SDK_AUTH_SP_NAME}"
@@ -374,6 +374,8 @@ echo "Purging key vault ${KEYVAULT_NAME} ..."
374374
az keyvault purge --name "${KEYVAULT_NAME}"
375375
echo "Deleting service principal ${CERT_AUTH_SP_NAME} ..."
376376
az ad sp delete --id "${CERT_AUTH_SP_ID}"
377+
echo "Deleting service principal ${AKV_SPAUTH_SP_NAME} ..."
378+
az ad sp delete --id "${AKV_SPAUTH_SP_OBJECTID}"
377379
EOF
378380

379381
# Only remove the test runner Service Principal if it was not pre-existing

0 commit comments

Comments
 (0)