Cosmos DB Output Binding - Conformance & Progress towards GA #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berndverst
force-pushed
the
bindings-cosmosdb-conformance
branch
from
26fc46a to
5d2b306
Compare
berndverst
changed the title
daixiang0
reviewed
Oct 12, 2021
Member
Author
|
@daixiang0 @CodeMonkeyLeet made some changes now By removing the upstream identification hydrator I was able to avoid the struct requirement that forced a particular Cosmos DB entity structure. Now we have complete flexibility again. Do note that the partition path specified upon table (collection) creation means this field / attribute must exist in every document sent to this output binding. |
berndverst
force-pushed
the
bindings-cosmosdb-conformance
branch
from
4ae795a to
49d25b5
Compare
daixiang0
reviewed
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 34.34% 34.85% +0.51%
==========================================
Files 140 141 +1
Lines 11993 12170 +177
==========================================
+ Hits 4119 4242 +123
- Misses 7450 7497 +47
- Partials 424 431 +7
Continue to review full report at Codecov.
|
artursouza
approved these changes
Oct 12, 2021
This was referenced Nov 18, 2021
halspang
pushed a commit
to halspang/components-contrib
that referenced
this pull request
Nov 29, 2021
* cosmosdb binding - not as flexible as I'd like conformance tests now pass * add tests for new UUID injection logic * Use nested property as partition key value * avoid repeated string constants * Disable Identification Hydrator to avoid struct requirement * Remove struct * Simplify PR * Add comments ofor code maintenance
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* cosmosdb binding - not as flexible as I'd like conformance tests now pass * add tests for new UUID injection logic * Use nested property as partition key value * avoid repeated string constants * Disable Identification Hydrator to avoid struct requirement * Remove struct * Simplify PR * Add comments ofor code maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Cosmos DB Conformance Tests Pass
Every document sent to the output binding must contain:
metadata.partitionKeyidthat is unique for this object in this collectionOther than that there are no limits to the document structure and the documented is inserted into Cosmos DB exactly as sent to the output binding.
Please note that upon creating a Cosmos DB Collection in Azure you must specify a partition key path. The path specified in the Cosmos DB Collection must also exist as a (nested) key in the Cosmos DB Binding request document. Additionally this key path must be specified in
metadata.partitionKey(but dot donations instead of slash notation is used)