-
Notifications
You must be signed in to change notification settings - Fork 543
1335 bugfix #2 #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
1335 bugfix #2 #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 35.02% 35.11% +0.08%
==========================================
Files 148 149 +1
Lines 12825 12842 +17
==========================================
+ Hits 4492 4509 +17
+ Misses 7853 7848 -5
- Partials 480 485 +5
Continue to review full report at Codecov.
|
berndverst
approved these changes
Dec 8, 2021
CrazyHZM
pushed a commit
to CrazyHZM/components-contrib
that referenced
this pull request
Dec 9, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const
CrazyHZM
pushed a commit
to CrazyHZM/components-contrib
that referenced
this pull request
Dec 9, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: Amit Mor <amit.mor@hotmail.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 10, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: Amit Mor <amit.mor@hotmail.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 10, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: Amit Mor <amit.mor@hotmail.com>
jigargandhi
pushed a commit
to jigargandhi/components-contrib
that referenced
this pull request
Dec 12, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
beiwei30
pushed a commit
to beiwei30/components-contrib
that referenced
this pull request
Dec 14, 2021
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: Ian Luo <ian.luo@gmail.com>
jigargandhi
pushed a commit
to jigargandhi/components-contrib
that referenced
this pull request
Jan 21, 2022
* bugfix for sns topic deletion upon termination * removed upstream github workflow files * Update snssqs.go * dapr bot schedule * read and append queue attributes * unnecessary escaping in json tag * unexporting structs * bugfix in policy * bugfix in policy. merged from master * fifo suffix as const Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1335
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: