Skip to content

Conversation

@amimimor
Copy link
Contributor

@amimimor amimimor commented Dec 8, 2021

Description

  • Bugfix - the created policy (of the previous bugfix) had a bug in Version and unescaping which caused AWS to reject the policy.
  • Minor refactoring - policy moved to a separate file. Const fifo suffix

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1335

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@amimimor amimimor requested review from a team as code owners December 8, 2021 10:48
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1368 (afd6dfb) into master (09fb60c) will increase coverage by 0.08%.
The diff coverage is 18.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   35.02%   35.11%   +0.08%     
==========================================
  Files         148      149       +1     
  Lines       12825    12842      +17     
==========================================
+ Hits         4492     4509      +17     
+ Misses       7853     7848       -5     
- Partials      480      485       +5     
Impacted Files Coverage Δ
authentication/azure/auth_amqp.go 0.00% <0.00%> (ø)
bindings/aws/kinesis/kinesis.go 2.61% <0.00%> (ø)
bindings/azure/eventgrid/eventgrid.go 3.84% <0.00%> (ø)
bindings/mqtt/mqtt.go 25.00% <0.00%> (-1.42%) ⬇️
configuration/redis/redis.go 37.22% <0.00%> (-1.12%) ⬇️
pubsub/aws/snssqs/policy.go 0.00% <0.00%> (ø)
pubsub/rocketmq/rocketmq.go 0.00% <0.00%> (ø)
state/azure/cosmosdb/cosmosdb.go 13.91% <0.00%> (-1.35%) ⬇️
state/query/query.go 23.91% <ø> (ø)
authentication/azure/auth.go 40.35% <1.96%> (-15.75%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac03db...afd6dfb. Read the comment docs.

@yaron2 yaron2 merged commit e97b1bf into dapr:master Dec 8, 2021
CrazyHZM pushed a commit to CrazyHZM/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const
CrazyHZM pushed a commit to CrazyHZM/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <amit.mor@hotmail.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <amit.mor@hotmail.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <amit.mor@hotmail.com>
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Dec 12, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
beiwei30 pushed a commit to beiwei30/components-contrib that referenced this pull request Dec 14, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Ian Luo <ian.luo@gmail.com>
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Jan 21, 2022
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS SQS/SNS Wrong queue access policy (broken in last version (1.5.0))

3 participants