Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Converting configuration API response from an array to dictionary #1771

Merged
merged 15 commits into from
Aug 25, 2022

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jun 1, 2022

Signed-off-by: Ian Luo ian.luo@gmail.com

Description

change items from array to dictionary, partially addresses #1770 (other configuration stores need to be updated)

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@beiwei30 beiwei30 requested review from a team as code owners June 1, 2022 09:40
@beiwei30
Copy link
Member Author

beiwei30 commented Jun 1, 2022

/cc @LaurenceLiZhixin pls. take a look.

Signed-off-by: Ian Luo <ian.luo@gmail.com>
beiwei30 added 2 commits June 1, 2022 18:06
Signed-off-by: Ian Luo <ian.luo@gmail.com>
@LaurenceLiZhixin
Copy link
Contributor

LGTM

@artursouza
Copy link
Member

Let's change this for 1.9 so we have time to update all SDKs. 1.8 is right around the corner.

@beiwei30 beiwei30 added this to the v1.9 milestone Jun 6, 2022
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Jul 22, 2022
@addjuarez addjuarez reopened this Aug 2, 2022
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 9, 2022

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Aug 9, 2022
@pravinpushkar
Copy link
Contributor

ping @beiwei30 @berndverst

@yaron2 yaron2 reopened this Aug 22, 2022
@dapr-bot dapr-bot removed the stale label Aug 22, 2022
@yaron2
Copy link
Member

yaron2 commented Aug 22, 2022

ping @beiwei30

@artursouza artursouza added the pinned Issue does not get stale label Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1771 (456d2d0) into master (e1db828) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   37.62%   37.62%           
=======================================
  Files         192      192           
  Lines       23982    23976    -6     
=======================================
- Hits         9023     9022    -1     
+ Misses      14193    14188    -5     
  Partials      766      766           
Impacted Files Coverage Δ
configuration/azure/appconfig/appconfig.go 41.89% <0.00%> (+1.36%) ⬆️
configuration/redis/redis.go 32.25% <100.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@berndverst berndverst merged commit b4ac240 into dapr:master Aug 25, 2022
@beiwei30 beiwei30 deleted the issue/1770 branch October 24, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Issue does not get stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants