-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Converting configuration API response from an array to dictionary #1771
Conversation
…dapr#1770 Signed-off-by: Ian Luo <ian.luo@gmail.com>
/cc @LaurenceLiZhixin pls. take a look. |
Signed-off-by: Ian Luo <ian.luo@gmail.com>
Signed-off-by: Ian Luo <ian.luo@gmail.com>
LGTM |
Let's change this for 1.9 so we have time to update all SDKs. 1.8 is right around the corner. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
ping @beiwei30 @berndverst |
ping @beiwei30 |
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
=======================================
Coverage 37.62% 37.62%
=======================================
Files 192 192
Lines 23982 23976 -6
=======================================
- Hits 9023 9022 -1
+ Misses 14193 14188 -5
Partials 766 766
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: Ian Luo ian.luo@gmail.com
Description
change items from array to dictionary, partially addresses #1770 (other configuration stores need to be updated)
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: