Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka - disable keeping metadata for all topics #3248

Closed
wants to merge 1 commit into from

Conversation

famarting
Copy link
Contributor

Description

Small change to the config of the kafka client used in all kafka components

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3247

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@famarting famarting requested review from a team as code owners November 23, 2023 13:40
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@famarting famarting force-pushed the kafka-metadata-full-disable branch from ade63c0 to 06b5f16 Compare November 23, 2023 14:54
@famarting
Copy link
Contributor Author

seems like this config option cannot be used without providing a known list of kafka topics...

@famarting famarting closed this Nov 23, 2023
@famarting famarting deleted the kafka-metadata-full-disable branch November 23, 2023 15:17
@artursouza
Copy link
Member

seems like this config option cannot be used without providing a known list of kafka topics...

Can that be passed as a parameter? Maybe there are users that have that scenario.

@olitomlinson
Copy link

@artursouza @yaron2

I think its worth reconsidering if there is a possible implementation here.

For context : we have a use case where thousands of partitions on the Kafka cluster are related to Kafka Topics that are never going to be used by Dapr sidecars. So having Dapr load all this metadata on init and refresh it is highly wasteful.

@artursouza
Copy link
Member

@artursouza @yaron2

I think its worth reconsidering if there is a possible implementation here.

For context : we have a use case where thousands of partitions on the Kafka cluster are related to Kafka Topics that are never going to be used by Dapr sidecars. So having Dapr load all this metadata on init and refresh it is highly wasteful.

I can consider one. Can you track your request in an issue? We can tag it and get some traction from the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka Sarama client, optimize by not loading all metadata
3 participants