Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes subscribeType metadata field not being respected for Pulsar pub sub #3603

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Nov 15, 2024

  • Fixes subscribeType metadata field not being respected
  • Fixes bug not allowing to connect to remote endpoints starting with pulsar:// or pulsar+ssl://

Currently, we have the subscribeType configuration field documented but not respected and the same field as subscription metadata is respected, but not documented.

var defaultSubscription = &common.Subscription{
		PubsubName: pubsubName,
		Topic:      topicName,
		Route:      "/orders",
		Metadata:   map[string]string{"subscribeType": "key_shared"},
	}

This PR uses the value in the configuration as default and overrides with the subscription metadata if one is set.

Issue reference

#3601

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

…t to remote endpoints starting with `pulsar://` or `pulsar+ssl://`

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska requested review from a team as code owners November 15, 2024 02:32
@elena-kolevska elena-kolevska changed the title Fixes subscription type not being parsed for Pulsar pub sub Fixes subscribeType metadata field not being respected for Pulsar pub sub Nov 15, 2024
@elena-kolevska elena-kolevska marked this pull request as draft November 15, 2024 02:53
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska marked this pull request as ready for review November 15, 2024 15:08
@yaron2
Copy link
Member

yaron2 commented Nov 15, 2024

The metadata YAML file needs to be updated

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@yaron2
Copy link
Member

yaron2 commented Nov 22, 2024

Build check is failing

@elena-kolevska
Copy link
Contributor Author

Build check is failing

Yeah, flaky test after merging master in, sorry. It's good now 🙏 .

@yaron2 yaron2 merged commit 2aea319 into dapr:main Nov 22, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants