[1.17] Close file after write #4034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-aliaga
force-pushed
the
sftp-close-file
branch
3 times, most recently
from
30d79d5 to
904278a
Compare
acroca
reviewed
Sep 22, 2025
javier-aliaga
force-pushed
the
sftp-close-file
branch
from
904278a to
1998bd1
Compare
acroca
approved these changes
Sep 22, 2025
sicoyle
previously approved these changes
Sep 22, 2025
javier-aliaga
force-pushed
the
sftp-close-file
branch
from
8d9d612 to
aad38f7
Compare
javier-aliaga
changed the title
javier-aliaga
force-pushed
the
sftp-close-file
branch
from
aad38f7 to
51ee3a3
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Co-authored-by: Sam <sam@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
sftp-close-file
branch
from
51ee3a3 to
ef87b3a
Compare
yaron2
approved these changes
Sep 23, 2025
kgal-akl
pushed a commit
to akeylesslabs/DAPR-components
that referenced
this pull request
Oct 22, 2025
Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Sam <sam@diagrid.io> Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some sftp servers requires the file to be closed to make it available to read
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #4016
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.