Skip to content

Conversation

@UmutComlekci
Copy link
Contributor

@UmutComlekci UmutComlekci commented Jul 3, 2021

Description

Adds support for TTL in Memcached State Store

Issue reference

#306

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

UPDATE

Moving this to 1.4, so will not be in 1.3 as part of #306

@ghost
Copy link

ghost commented Jul 3, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me implement this in other state stores.

defaultMaxIdleConnections = 2
defaultTimeout = 1000 * time.Millisecond
defaultMaxIdleConnections = 2
defaultTimeout = 1000 * time.Millisecond
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo this whitespace change please?

UmutComlekci and others added 2 commits July 6, 2021 23:05
Co-authored-by: Bernd Verst <berndverst@users.noreply.github.com>
Co-authored-by: Bernd Verst <berndverst@users.noreply.github.com>
@artursouza artursouza requested review from a team as code owners July 14, 2021 01:50
@artursouza artursouza added this to the v1.4 milestone Jul 14, 2021
@artursouza
Copy link
Contributor

Moving this to 1.4, so will not be in 1.3 as part of #306

@berndverst
Copy link
Member

@UmutComlekci to make sure you get credit for the contribution I am going to fork your fork and will patch this up and make a new PR. Today is code freeze for the 1.3 release and I want to make sure this can get in!

@UmutComlekci
Copy link
Contributor Author

@UmutComlekci to make sure you get credit for the contribution I am going to fork your fork and will patch this up and make a new PR. Today is code freeze for the 1.3 release and I want to make sure this can get in!

Sorry for delay and thank you very much for all your help :)

@berndverst
Copy link
Member

@artursouza we should close this PR as it is continued in #1011

@artursouza artursouza closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants