-
Notifications
You must be signed in to change notification settings - Fork 543
Adds support for TTL in Memcached State Store #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
berndverst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping me implement this in other state stores.
state/memcached/memcached.go
Outdated
| defaultMaxIdleConnections = 2 | ||
| defaultTimeout = 1000 * time.Millisecond | ||
| defaultMaxIdleConnections = 2 | ||
| defaultTimeout = 1000 * time.Millisecond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo this whitespace change please?
Co-authored-by: Bernd Verst <berndverst@users.noreply.github.com>
Co-authored-by: Bernd Verst <berndverst@users.noreply.github.com>
|
Moving this to 1.4, so will not be in 1.3 as part of #306 |
|
@UmutComlekci to make sure you get credit for the contribution I am going to fork your fork and will patch this up and make a new PR. Today is code freeze for the 1.3 release and I want to make sure this can get in! |
Sorry for delay and thank you very much for all your help :) |
|
@artursouza we should close this PR as it is continued in #1011 |
Description
Adds support for TTL in Memcached State Store
Issue reference
#306
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
UPDATE
Moving this to 1.4, so will not be in 1.3 as part of #306