-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent github workflow from failing if windows integration tests fail #6704
Prevent github workflow from failing if windows integration tests fail #6704
Conversation
Signed-off-by: joshvanl <me@joshvanl.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to unblock builds, but can we also try to make the Windows tests work?
Codecov Report
@@ Coverage Diff @@
## master #6704 +/- ##
==========================================
+ Coverage 65.15% 65.20% +0.04%
==========================================
Files 208 208
Lines 19388 19395 +7
==========================================
+ Hits 12632 12646 +14
+ Misses 5723 5712 -11
- Partials 1033 1037 +4
|
I agree. I would like to know why daprd seems to completely break down in serving on CPU constrained environments- assuming that is the issue. It doesn't seem windows OS specific to me. |
We know from prior experience that the Windows agents are slower. Not sure exactly why, but it may be related to the OS being heavier and the fact that it runs more complex anti-malware. Even I/O is significantly slower. I also mentioned on Discord that I think we should change the ITs to run without the |
I'll open a PR to remove the |
/cc @artursouza