Skip to content

[kafka] updates to bindings and pubsub component docs#2552

Merged
msfussell merged 7 commits intodapr:v1.7from
hhunter-ms:issue_2437
Jun 24, 2022
Merged

[kafka] updates to bindings and pubsub component docs#2552
msfussell merged 7 commits intodapr:v1.7from
hhunter-ms:issue_2437

Conversation

@hhunter-ms
Copy link
Contributor

Signed-off-by: Hannah Hunter hannahhunter@microsoft.com

Description

Added supported features to tables

Issue reference

PR will close: #2437

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners June 21, 2022 21:13
@msfussell
Copy link
Member

@skyao @berndverst - Please take a look at this

@hhunter-ms hhunter-ms added this to the 1.8 milestone Jun 23, 2022
@msfussell msfussell requested review from berndverst and skyao June 24, 2022 02:59
@skyao
Copy link
Member

skyao commented Jun 24, 2022

@hhunter-ms @msfussell @berndverst

In kafka pubsub component document, there is a long chapter named "Authentication".

Now after refactory, all the authentication method of kafka pubsub component document are supported in kafka binding component. So we need to copy these "Authentication" content to kafka binding component.

Or, since the "Authentication" content are exactly the same (now the two component use the same code to do kafka connection and authentication), can we "reference" in the two document and not so many duplicated content?

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@msfussell
Copy link
Member

@hhunter-ms @msfussell @berndverst

In kafka pubsub component document, there is a long chapter named "Authentication".

Now after refactory, all the authentication method of kafka pubsub component document are supported in kafka binding component. So we need to copy these "Authentication" content to kafka binding component.

Or, since the "Authentication" content are exactly the same (now the two component use the same code to do kafka connection and authentication), can we "reference" in the two document and not so many duplicated content?

I suggest that we keep this in the pub/sub component, since this is the most heavily used and then reference this section from the Binding. @hhunter-ms - could you update this?

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
hhunter-ms and others added 2 commits June 24, 2022 16:36
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msfussell msfussell merged commit bb27ffd into dapr:v1.7 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document for kafka binding component and kakfa pubsub component need to update

3 participants