Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/outbound path for health checks #4043

Merged
merged 21 commits into from
Mar 4, 2024
Merged

/outbound path for health checks #4043

merged 21 commits into from
Mar 4, 2024

Conversation

hhunter-ms
Copy link
Collaborator

Description

  • Add info about /outbound path and behavior to API doc
  • Add diagram to Sidecar Health doc

Issue reference

PR will close: #3704

@hhunter-ms
initial add, need to create diagram to replace placeholder
42fdb2b 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms added this to the 1.13 milestone Feb 21, 2024
@hhunter-ms hhunter-ms self-assigned this Feb 21, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners February 21, 2024 19:48
hhunter-ms and others added 4 commits February 21, 2024 14:48
@hhunter-ms
Merge branch 'v1.13' into issue_3704
9a5172f
@hhunter-ms
update diagram
2fb2ed3 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'issue_3704' of https://github.com/hhunter-ms/docs into …
86dfaa6 
…issue_3704
@hhunter-ms
add diagram
4abce50 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@msfussell
Copy link
Member

Also need to update https://docs.dapr.io/reference/environment/ to add DAPR_HEALTH_TIMEOUTThe default timeout is 60 seconds, but it can be overridden by setting theDAPR_HEALTH_TIMEOUT`
Used by SDK to set the time on the Wait for Sidecar availability
See https://github.com/dapr/python-sdk/pull/670/files

Also fix spelling mistake On client initialisation, a health check is performed against the Dapr sidecar (/healthz/outboud) for outbound

hhunter-ms and others added 4 commits March 1, 2024 12:10
@hhunter-ms
updates per mark
103ea58 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'issue_3704' of https://github.com/hhunter-ms/docs into …
e5f9dc0 
…issue_3704
@hhunter-ms
edit and add cross-linking
e176899 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'v1.13' into issue_3704
25739a0
msfussell
msfussell reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good. Here are suggested changes.

daprdocs/content/en/operations/resiliency/health-checks/sidecar-health.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/resiliency/health-checks/sidecar-health.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/resiliency/health-checks/sidecar-health.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/health_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/resiliency/health-checks/sidecar-health.md Show resolved Hide resolved
@hhunter-ms hhunter-ms merged commit 0632429 into dapr:v1.13 Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@olitomlinson olitomlinson Awaiting requested review from olitomlinson

Assignees

@hhunter-ms hhunter-ms

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
2 participants
@hhunter-ms @msfussell