Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates API ref for jobs. Adds doc on Kubernetes Scheduler persistent #4256

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Updates API ref for jobs. Adds doc on Kubernetes Scheduler persistent #4256

merged 15 commits into from
Jul 26, 2024

Conversation

JoshVanL
Copy link
Contributor

No description provided.

@JoshVanL
Updates API ref for jobs. Adds doc on Kubernetes Scheduler persistent
e0d3561 
volume

Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL JoshVanL requested review from a team as code owners July 10, 2024 15:23
hhunter-ms
hhunter-ms reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removing localized links to clear error

daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
@JoshVanL @hhunter-ms
Apply suggestions from code review
c07bb94 
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
@JoshVanL JoshVanL mentioned this pull request Jul 10, 2024
Merged
7 tasks
@hhunter-ms hhunter-ms added this to the 1.14 milestone Jul 11, 2024
@hhunter-ms hhunter-ms linked an issue Jul 11, 2024 that may be closed by this pull request
Distributed Scheduler API building block docs #3915
Closed
13 tasks
hhunter-ms
hhunter-ms requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

daprdocs/content/en/developing-applications/building-blocks/jobs/howto-schedule-jobs.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/jobs_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/jobs_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/jobs_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/jobs_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/cli/dapr-init.md Outdated Show resolved Hide resolved
JoshVanL and others added 2 commits July 16, 2024 18:04
@JoshVanL @hhunter-ms
Apply suggestions from code review
6b5ab32 
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
@JoshVanL
Adds reference for file system location of scheduler local volume
90a81fd 
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
cicoyle approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one spelling nit, but otherwise looks great 🎉

JoshVanL and others added 2 commits July 17, 2024 15:02
@JoshVanL @cicoyle
Update daprdocs/content/en/reference/api/jobs_api.md
584bf60 
Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com>
Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
@JoshVanL
Merge branch 'v1.14' into jobs-api-ref
02d98de
@msfussell
Update daprdocs/content/en/operations/hosting/self-hosted/self-hosted…
fc57e56 
…-persisting-scheduler.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
msfussell
msfussell reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly on the default for dapr init command

daprdocs/content/en/operations/hosting/self-hosted/self-hosted-persisting-scheduler.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/cli/dapr-init.md Outdated Show resolved Hide resolved
daprdocs/content/en/operations/hosting/self-hosted/self-hosted-persisting-scheduler.md Outdated Show resolved Hide resolved
@msfussell msfussell mentioned this pull request Jul 24, 2024
Closed
JoshVanL and others added 3 commits July 24, 2024 17:23
@JoshVanL @msfussell
Apply suggestions from code review
94bc607 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
@JoshVanL
Adds default volume name for scheduler dapr init
9086fd9 
Signed-off-by: joshvanl <me@joshvanl.dev>
@msfussell
Merge branch 'v1.14' into jobs-api-ref
58c04f9
msfussell
msfussell approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@msfussell
Copy link
Member

DO not merge this yet. @JoshVanL will add one more update.

@JoshVanL
Adds directions for getting scheduler volume from Docker Desktop
98deed6 
Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL
Copy link
Contributor Author

@msfussell updated- please take a look!

@msfussell
Update daprdocs/content/en/operations/hosting/self-hosted/self-hosted…
ec77221 
…-persisting-scheduler.md

Signed-off-by: Mark Fussell <markfussell@gmail.com>
@msfussell msfussell merged commit 2deca48 into dapr:v1.14 Jul 26, 2024
4 checks passed
@jjcollinge jjcollinge mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@rochabr rochabr rochabr left review comments

@hhunter-ms hhunter-ms hhunter-ms approved these changes

@cicoyle cicoyle cicoyle approved these changes

Assignees

@JoshVanL JoshVanL

Labels
do-not-merge
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

Distributed Scheduler API building block docs
5 participants
@JoshVanL @msfussell @rochabr @cicoyle @hhunter-ms