Skip to content

Conversation

@elena-kolevska
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 2, 2024
@hhunter-ms hhunter-ms added this to the 1.15 milestone Dec 2, 2024
@hhunter-ms hhunter-ms removed the stale label Dec 2, 2024
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny review

elena-kolevska and others added 2 commits December 3, 2024 14:40
…ersisting-scheduler.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 10, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see comment here #4452 in that we need to describe how to set up HA mode. If this is Kubernetes specific, then can be added to this article. Please coordinate with @cicoyle

Also @hhunter-ms - All the headings in this article are upper case and need to be lower case. Maybe include this in another update or Elena if you can do this.

elena-kolevska and others added 2 commits December 12, 2024 17:21
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 077b052 into dapr:v1.15 Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants