Skip to content

Conversation

@hhunter-ms
Copy link
Contributor

@hhunter-ms hhunter-ms commented Jan 14, 2025

Description

  • Break up policies doc to help with user path
  • Beef up some of the docs using presentation from @bibryam
  • Add section for HTTP and gRPC status codes per @bibryam
  • Update links to prevent breaking
  • Add limitation/note about resiliency not being supported for service invocation via gRPC

Issue reference

#4463
#4440

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms self-assigned this Jan 14, 2025
@hhunter-ms hhunter-ms requested review from a team as code owners January 14, 2025 22:12
hhunter-ms and others added 2 commits January 15, 2025 10:47
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms linked an issue Jan 15, 2025 that may be closed by this pull request
@hhunter-ms hhunter-ms linked an issue Jan 15, 2025 that may be closed by this pull request
@hhunter-ms hhunter-ms requested a review from rochabr January 15, 2025 16:18
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Contributor

@bibryam bibryam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small fixes needed. The rest looks good

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@github-actions
Copy link

Stale PR, paging all reviewers

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and then we can merge this.


## Demo

Watch a demo presented during [Diagrid's Dapr v1.15 celebration](https://www.diagrid.io/videos/dapr-1-15-deep-dive) to see how to set retry status code filters using Diagrid Conductor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Watch a demo presented during [Diagrid's Dapr v1.15 celebration](https://www.diagrid.io/videos/dapr-1-15-deep-dive) to see how to set retry status code filters using Diagrid Conductor
Watch a demo presented during [Diagrid's Dapr v1.15 celebration](https://www.diagrid.io/videos/dapr-1-15-deep-dive) to see how to set retry status code filters.

@hhunter-ms hhunter-ms merged commit df5f21a into dapr:v1.15 Feb 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo and Update Resiliency Policies section overview Add information to Resiliency Policy page for Dapr's gRPC support.

4 participants