Skip to content

Conversation

@ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Apr 30, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Update doc for dapr/components-contrib#3700 and it's the duplicate PR with #4582 but suggested to target on v1.16 so this new PR was created based on the 1.16 branch.

Issue reference

@ericsyh ericsyh requested review from a team as code owners April 30, 2025 01:47
@ericsyh ericsyh changed the title feat(pulsar): support subscribeInitialPosition on Pulsar consumer [docs-1.16](pulsar): support subscribeInitialPosition on Pulsar consumer Apr 30, 2025
@ericsyh
Copy link
Contributor Author

ericsyh commented Apr 30, 2025

@cicoyle I created this based on 1.16 to replace the #4582

@cicoyle
Copy link
Contributor

cicoyle commented Apr 30, 2025

Can you run the DCO commands? @ericsyh

Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@ericsyh ericsyh force-pushed the support-pulsarsubscribeInitialPosition branch from 9c83236 to 577fa01 Compare April 30, 2025 02:08
@ericsyh
Copy link
Contributor Author

ericsyh commented Apr 30, 2025

Can you run the DCO commands? @ericsyh

Sure, added the sign-off on commit.

@yaron2 yaron2 merged commit 49d74a5 into dapr:v1.16 Apr 30, 2025
4 checks passed
@yaron2 yaron2 added this to the 1.16 milestone Apr 30, 2025
@marcduiker
Copy link
Contributor

@holopin-bot @ericsyh Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot
Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @ericsyh, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbrzciyg277507laylhz8va6

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants