Skip to content

Commit

Permalink
Support gRPC richer error model (#1436)
Browse files Browse the repository at this point in the history
* First pass at supporting richer error model in Dapr .NET SDK

Signed-off-by: jev-e <jev@jev.org.uk>
Signed-off-by: jev <jacob@jev.org.uk>

* Add ExtendedErrorDetailFactory, move to seperate files / new folder, add test file.

Signed-off-by: jev <jacob@jev.org.uk>

* Flesh out + rename tests file, tidy more comments.

Signed-off-by: jev <jacob@jev.org.uk>

* Add metadata to ErrorInfo details, add tests for each details type, multiple details

Signed-off-by: jev jacob@jev.org.uk
Signed-off-by: jev <jacob@jev.org.uk>

* Tidy up comments, add copyright to file.

Signed-off-by: jev jacob@jev.org.uk
Signed-off-by: jev <jacob@jev.org.uk>

* add and use constants, more docs tidy up.

Signed-off-by: jev jacob@jev.org.uk
Signed-off-by: jev <jacob@jev.org.uk>

* add initial docs pages for error handling in .net sdk.

Signed-off-by: jev jacob@jev.org.uk
Signed-off-by: jev <jacob@jev.org.uk>

* write daprdocs detailing usage of extendedErrorInfo, rename vars

signed-off-by: jev jacob@jev.org.uk
Signed-off-by: jev <jacob@jev.org.uk>

* Address PR comments

Signed-off-by: jev <jacob@jev.org.uk>

* pr comment; adjust weight

Signed-off-by: jev <jacob@jev.org.uk>

---------

Signed-off-by: jev-e <jev@jev.org.uk>
Signed-off-by: jev <jacob@jev.org.uk>
Signed-off-by: jev jacob@jev.org.uk
  • Loading branch information
jev-e authored Dec 28, 2024
1 parent a61db8b commit da8b21b
Show file tree
Hide file tree
Showing 10 changed files with 1,324 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
type: docs
title: "Error Handling in the Dapr .NET SDK"
linkTitle: "Error handling"
weight: 90000
description: Learn about error handling in the Dapr.NET SDK.
---
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
---
type: docs
title: "Richer Error Model in the Dapr .NET SDK"
linkTitle: "Richer error model"
weight: 59000
description: Learn how to use the richer error model in the .NET SDK.
---

The Dapr .NET SDK supports the richer error model, implemented by the Dapr runtime. This model provides a way for applications to enrich their errors with added context,
allowing consumers of the application to better understand the issue and resolve faster. You can read more about the richer error model [here](https://google.aip.dev/193), and you
can find the Dapr proto file implementing these errors [here](https://github.com/googleapis/googleapis/blob/master/google/rpc/error_details.proto").

The Dapr .NET SDK implements all details supported by the Dapr runtime, implemented in the `Dapr.Common.Exceptions` namespace, and is accessible through
the `DaprException` extension method `TryGetExtendedErrorInfo`. Currently this detail extraction is only supported for
`RpcException`'s where the details are present.

```csharp
// Example usage of ExtendedErrorInfo
try
{
// Perform some action with the Dapr client that throws a DaprException.
}
catch (DaprException daprEx)
{
if (daprEx.TryGetExtendedErrorInfo(out DaprExtendedErrorInfo errorInfo)
{
Console.WriteLine(errorInfo.Code);
Console.WriteLine(errorInfo.Message);

foreach (DaprExtendedErrorDetail detail in errorInfo.Details)
{
Console.WriteLine(detail.ErrorType);
switch (detail.ErrorType)
case ExtendedErrorType.ErrorInfo:
Console.WriteLine(detail.Reason);
Console.WriteLine(detail.Domain);
default:
Console.WriteLine(detail.TypeUrl);
}
}
}
```

## DaprExtendedErrorInfo

Contains `Code` (the status code) and `Message` (the error message) associated with the error, parsed from an inner `RpcException`.
Also contains a collection of `DaprExtendedErrorDetails` parsed from the details in the exception.

## DaprExtendedErrorDetail

All details implement the abstract `DaprExtendedErrorDetail` and have an associated `DaprExtendedErrorType`.

1. [RetryInfo](#retryinfo)

2. [DebugInfo](#debuginfo)

3. [QuotaFailure](#quotafailure)

4. [PreconditionFailure](#preconditionfailure)

5. [RequestInfo](#requestinfo)

6. [LocalizedMessage](#localizedmessage)

7. [BadRequest](#badrequest)

8. [ErrorInfo](#errorinfo)

9. [Help](#help)

10. [ResourceInfo](#resourceinfo)

11. [Unknown](#unknown)

## RetryInfo

Information telling the client how long to wait before they should retry. Provides a `DaprRetryDelay` with the properties
`Second` (offset in seconds) and `Nano` (offset in nanoseconds).

## DebugInfo

Debugging information offered by the server. Contains `StackEntries` (a collection of strings containing the stack trace), and
`Detail` (further debugging information).

## QuotaFailure

Information relating to some quota that may have been reached, such as a daily usage limit on an API. It has one property `Violations`,
a collection of `DaprQuotaFailureViolation`, which each contain a `Subject` (the subject of the request) and `Description` (further information regarding the failure).

## PreconditionFailure

Information informing the client that some required precondition was not met. Has one property `Violations`, a collection of
`DaprPreconditionFailureViolation`, which each has `Subject` (subject where the precondition failure occured e.g. "Azure"), `Type` (representation of the precondition type e.g. "TermsOfService"), and `Description` (further description e.g. "ToS must be accepted.").

## RequestInfo

Information returned by the server that can be used by the server to identify the clients request. Contains
`RequestId` and `ServingData` properties, `RequestId` being some string (such as a UID) the server can interpret,
and `ServingData` being some arbitrary data that made up part of the request.

## LocalizedMessage

Contains a localized message, along with the locale of the message. Contains `Locale` (the locale e.g. "en-US") and `Message` (the localized message).

## BadRequest

Describes a bad request field. Contains collection of `DaprBadRequestDetailFieldViolation`, which each has `Field` (the offending field in request e.g. 'first_name') and
`Description` (further information detailing the reason e.g. "first_name cannot contain special characters").

## ErrorInfo

Details the cause of an error. Contains three properties, `Reason` (the reason for the error, which should take the form of UPPER_SNAKE_CASE e.g. DAPR_INVALID_KEY),
`Domain` (domain the error belongs to e.g. 'dapr.io'), and `Metadata`, a key value based collection of futher information.

## Help

Provides resources for the client to perform further research into the issue. Contains a collection of `DaprHelpDetailLink`,
which provides `Url` (a url to help or documentation), and `Description` (a description of what the link provides).

## ResourceInfo

Provides information relating to an accessed resource. Provides three properties `ResourceType` (type of the resource being access e.g. "Azure service bus"),
`ResourceName` (The name of the resource e.g. "my-configured-service-bus"), `Owner` (the owner of the resource e.g. "subscriptionowner@dapr.io"),
and `Description` (further information on the resource relating to the error e.g. "missing permissions to use this resource").

## Unknown

Returned when the detail type url cannot be mapped to the correct `DaprExtendedErrorDetail` implementation.
Provides one property `TypeUrl` (the type url that could not be parsed e.g. "type.googleapis.com/Google.rpc.UnrecognizedType").










1 change: 1 addition & 0 deletions src/Dapr.Common/Dapr.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Google.Api.CommonProtos" />
<PackageReference Include="Grpc.Net.Client" />
<PackageReference Include="Microsoft.Extensions.Http" />
<PackageReference Include="Microsoft.Extensions.Configuration" />
Expand Down
55 changes: 55 additions & 0 deletions src/Dapr.Common/Exceptions/DaprExceptionExtensions.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// ------------------------------------------------------------------------
// Copyright 2024 The Dapr Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// ------------------------------------------------------------------------

using System.Diagnostics.CodeAnalysis;
using Grpc.Core;

namespace Dapr.Common.Exceptions
{
/// <summary>
/// Provides extension methods for <see cref="DaprException"/>.
/// </summary>
public static class DaprExceptionExtensions
{
/// <summary>
/// Attempt to retrieve <see cref="DaprExtendedErrorInfo"/> from <see cref="DaprException"/>.
/// </summary>
/// <param name="exception">A Dapr exception. <see cref="DaprException"/>.</param>
/// <param name="daprExtendedErrorInfo"><see cref="DaprExtendedErrorInfo"/> out if parsable from inner exception, null otherwise.</param>
/// <returns>True if extended info is available, false otherwise.</returns>
public static bool TryGetExtendedErrorInfo(this DaprException exception, [NotNullWhen(true)] out DaprExtendedErrorInfo? daprExtendedErrorInfo)
{
daprExtendedErrorInfo = null;
if (exception.InnerException is not RpcException rpcException)
{
return false;
}

var metadata = rpcException.Trailers.Get(DaprExtendedErrorConstants.GrpcDetails);

if (metadata is null)
{
return false;
}

var status = Google.Rpc.Status.Parser.ParseFrom(metadata.ValueBytes);

daprExtendedErrorInfo = new DaprExtendedErrorInfo(status.Code, status.Message)
{
Details = status.Details.Select(detail => ExtendedErrorDetailFactory.CreateErrorDetail(detail)).ToArray(),
};

return true;
}
}
}
34 changes: 34 additions & 0 deletions src/Dapr.Common/Exceptions/DaprExtendedErrorConstants.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// ------------------------------------------------------------------------
// Copyright 2024 The Dapr Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// http://www.apache.org/licenses/LICENSE-2.0
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// ------------------------------------------------------------------------

namespace Dapr.Common.Exceptions
{
/// <summary>
/// Definitions of expected types to be returned from the Dapr runtime.
/// </summary>
internal static class DaprExtendedErrorConstants
{
public const string ErrorDetailTypeUrl = "type.googleapis.com/";
public const string GrpcDetails = "grpc-status-details-bin";
public const string ErrorInfo = $"{ErrorDetailTypeUrl}Google.rpc.ErrorInfo";
public const string RetryInfo = $"{ErrorDetailTypeUrl}Google.rpc.RetryInfo";
public const string DebugInfo = $"{ErrorDetailTypeUrl}Google.rpc.DebugInfo";
public const string QuotaFailure = $"{ErrorDetailTypeUrl}Google.rpc.QuotaFailure";
public const string PreconditionFailure = $"{ErrorDetailTypeUrl}Google.rpc.PreconditionFailure";
public const string BadRequest = $"{ErrorDetailTypeUrl}Google.rpc.BadRequest";
public const string RequestInfo = $"{ErrorDetailTypeUrl}Google.rpc.RequestInfo";
public const string ResourceInfo = $"{ErrorDetailTypeUrl}Google.rpc.ResourceInfo";
public const string Help = $"{ErrorDetailTypeUrl}Google.rpc.Help";
public const string LocalizedMessage = $"{ErrorDetailTypeUrl}Google.rpc.LocalizedMessage";
}
}
Loading

0 comments on commit da8b21b

Please sign in to comment.