Provide the ability to Mock WorkflowActivityContext #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siri-varma It looks like the DCO check failed. Could you please make sure each of your commits are signed? |
Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com>
Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com>
siri-varma
force-pushed
the
users/svegira/make-context-mockable
branch
from
a0e576f to
f51def0
Compare
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Removed duplicate project include of Dapr.Workflow.Test Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
|
@siri-varma Looks like we've got several build errors regarding nullability. If you can fix those, I'd appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the WorkflowActivityContext abstract.
Created DaprWorkflowActivityContext and made it inherit from WorkflowActivityContext
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1200
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: