Conversation builder consistency changes #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
changed the title
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Dec 11, 2024
…apr#1423 Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
added a commit
that referenced
this pull request
Dec 12, 2024
* Updated documentation to reflect new DaprClient DI injection capabilities Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Clarified relationship between DAPR_HTTP_ENDPOINT and DAPR_HTTP_PORT as well as DAPR_GRPC_ENDPOINT and DAPR_GRPC_PORT. Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Clarified configuration prioritization order on DaprClientBuilder as of 1.15 and provided more information/example around sourcing from IConfiguration. Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Fixed typo - great catch Philip! Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added information about using Dapr.Jobs favoring dependency injection Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Building out .NET AI docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Building out .NET AI docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added first-draft of .NET Aspire docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added first-draft of .NET Aspire docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added first-draft of .NET Aspire docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Reordered the weighting of the development docs to reflect investment level Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated .NET SDK links to point to a better endpoint Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated more of the .NET SDK links Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Reweighted document order Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Building out pubsub docs Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Tweak to clarify use of the Dapr SDK Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added missing whitespace for clarity Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Simplified alert about .NET versioning Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added Dapr.Jobs as a prereq Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added some minor formatting tweaks Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added body of the pubsub how to documentation Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated table layout + reformatted Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added note about using DI functionality in best practices Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Fixed several typos Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Corrected updated overload Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added best practices documentation for PubSub functionality Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated contribution guide Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added current .NET version support to contributor guide Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Minor word addition Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Renamed for consistency Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Tweaks to introduction text Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added Conversation usage documentation Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated to reflect updated extension method name following merge of #1423 Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Built out Jobs introduction Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Updated support message for Dapr.Workflows Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While writing up the documentation for each, I realized that the conversation builder had an inconsistency naming convention. This fixes that, the associated unit tests and example and also fixes another unit test that was incorrect in the Jobs API.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: